fix(plugins): update sample plugin imports to use package subpath exports#1484
Open
coopernetes wants to merge 2 commits intomainfrom
Open
fix(plugins): update sample plugin imports to use package subpath exports#1484coopernetes wants to merge 2 commits intomainfrom
coopernetes wants to merge 2 commits intomainfrom
Conversation
…orts The sample plugins were importing directly from internal source paths (`@finos/git-proxy/src/plugin.js`, `@finos/git-proxy/src/proxy/actions`) which are not defined in the package exports map and throw ERR_PACKAGE_PATH_NOT_EXPORTED at runtime. Update to use the correct exported subpaths (`@finos/git-proxy/plugin`, `@finos/git-proxy/proxy/actions`) as defined in package.json exports. Bump package version to 0.1.2 and peer dependency to ^2.0.0-rc.6. Depends on #1480 (fix(npm): replace .npmignore with files allowlist).
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1484 +/- ##
=======================================
Coverage 89.66% 89.66%
=======================================
Files 68 68
Lines 4869 4869
Branches 888 888
=======================================
Hits 4366 4366
Misses 485 485
Partials 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coopernetes
commented
Mar 26, 2026
Signed-off-by: Thomas Cooper <57812123+coopernetes@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
index.jsandexample.cjsingit-proxy-plugin-samplesto import from the correct package subpath exports (@finos/git-proxy/plugin,@finos/git-proxy/proxy/actions) instead of internal source paths (@finos/git-proxy/src/plugin.js,@finos/git-proxy/src/proxy/actions) which are not defined in the exports map and throwERR_PACKAGE_PATH_NOT_EXPORTEDat runtime@finos/git-proxy-plugin-samplesto0.1.2^2.0.0Blocked on
Depends on #1480 — the
dist/src/content (where subpath exports resolve to) is excluded from the published package until that PR's.npmignore→filesallowlist change lands.Test plan
npm installinplugins/git-proxy-plugin-samplesagainst the published2.0.0tarballrequire('@finos/git-proxy/plugin')andimport ... from '@finos/git-proxy/plugin'resolve withoutERR_PACKAGE_PATH_NOT_EXPORTED@finos/git-proxy-plugin-samples@0.1.2