Conversation
Replaces .npmignore with files allowlist in package.json
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1480 +/- ##
=======================================
Coverage 89.66% 89.66%
=======================================
Files 68 68
Lines 4869 4869
Branches 888 888
=======================================
Hits 4366 4366
Misses 485 485
Partials 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@coopernetes Should be ready for a look! The CI failure is being fixed in #1482 which requires a quick review and an admin push to bypass the Required check. |
…orts The sample plugins were importing directly from internal source paths (`@finos/git-proxy/src/plugin.js`, `@finos/git-proxy/src/proxy/actions`) which are not defined in the package exports map and throw ERR_PACKAGE_PATH_NOT_EXPORTED at runtime. Update to use the correct exported subpaths (`@finos/git-proxy/plugin`, `@finos/git-proxy/proxy/actions`) as defined in package.json exports. Bump package version to 0.1.2 and peer dependency to ^2.0.0-rc.6. Depends on #1480 (fix(npm): replace .npmignore with files allowlist).
Signed-off-by: Thomas Cooper <57812123+coopernetes@users.noreply.github.com>
|
Thanks @jescalada for the quick fix on this one, much appreciated! I'll get the samples updated as per #1484 |
|
I guess we need a v2.0.0-rc6 to test after this is merged? |
|
@coopernetes Just needs a final approval! Should we cut the v2 right after this and #1484 are merged, or is an |
Selfishly yes if we can. This gives us a smooth upgrade path with our existing plugins. |
I don't want to hold up the train, if there are further challenges with plugins we can cut a 2.0.1 bug fix. |
|
@kriswest would you mind giving this an approval? I was being too helpful it seems.
|
|
@finos/git-proxy-maintainers one more approval needed |
Fixes #1474. Replaces
.npmignorewith files allowlist inpackage.jsonTested by running
npm run build && npm packand then, in a separate directory, installing the generated tarball and runningnode -e "require('@finos/git-proxy/plugin')".Are there any other files/directories that should be included in the package other than the schema and default config?