Skip to content

fix: broken plugin exports#1480

Open
jescalada wants to merge 4 commits intomainfrom
1474-fix-broken-subpath-exports
Open

fix: broken plugin exports#1480
jescalada wants to merge 4 commits intomainfrom
1474-fix-broken-subpath-exports

Conversation

@jescalada
Copy link
Copy Markdown
Contributor

Fixes #1474. Replaces .npmignore with files allowlist in package.json

Tested by running npm run build && npm pack and then, in a separate directory, installing the generated tarball and running node -e "require('@finos/git-proxy/plugin')".

Are there any other files/directories that should be included in the package other than the schema and default config?

Replaces .npmignore with files allowlist in package.json
@jescalada jescalada requested a review from a team as a code owner March 25, 2026 03:38
@netlify
Copy link
Copy Markdown

netlify bot commented Mar 25, 2026

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit bc306e8
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/69c5f35aa812a50008dc085f

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 25, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA bc306e8.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.66%. Comparing base (4e2eea8) to head (bc306e8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1480   +/-   ##
=======================================
  Coverage   89.66%   89.66%           
=======================================
  Files          68       68           
  Lines        4869     4869           
  Branches      888      888           
=======================================
  Hits         4366     4366           
  Misses        485      485           
  Partials       18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jescalada jescalada requested a review from coopernetes March 25, 2026 04:17
@jescalada
Copy link
Copy Markdown
Contributor Author

@coopernetes Should be ready for a look! The CI failure is being fixed in #1482 which requires a quick review and an admin push to bypass the Required check.

coopernetes added a commit that referenced this pull request Mar 26, 2026
…orts

The sample plugins were importing directly from internal source paths
(`@finos/git-proxy/src/plugin.js`, `@finos/git-proxy/src/proxy/actions`)
which are not defined in the package exports map and throw
ERR_PACKAGE_PATH_NOT_EXPORTED at runtime.

Update to use the correct exported subpaths (`@finos/git-proxy/plugin`,
`@finos/git-proxy/proxy/actions`) as defined in package.json exports.

Bump package version to 0.1.2 and peer dependency to ^2.0.0-rc.6.

Depends on #1480 (fix(npm): replace .npmignore with files allowlist).
Signed-off-by: Thomas Cooper <57812123+coopernetes@users.noreply.github.com>
@coopernetes coopernetes enabled auto-merge March 26, 2026 03:52
@coopernetes
Copy link
Copy Markdown
Contributor

Thanks @jescalada for the quick fix on this one, much appreciated! I'll get the samples updated as per #1484

@kriswest
Copy link
Copy Markdown
Contributor

I guess we need a v2.0.0-rc6 to test after this is merged?

@jescalada jescalada requested a review from coopernetes March 26, 2026 14:48
@jescalada
Copy link
Copy Markdown
Contributor Author

@coopernetes Just needs a final approval! Should we cut the v2 right after this and #1484 are merged, or is an rc.6 necessary to be sure?

@coopernetes
Copy link
Copy Markdown
Contributor

I guess we need a v2.0.0-rc6 to test after this is merged?

Selfishly yes if we can. This gives us a smooth upgrade path with our existing plugins.

@coopernetes
Copy link
Copy Markdown
Contributor

@coopernetes Just needs a final approval! Should we cut the v2 right after this and #1484 are merged, or is an rc.6 necessary to be sure?

I don't want to hold up the train, if there are further challenges with plugins we can cut a 2.0.1 bug fix.

@coopernetes
Copy link
Copy Markdown
Contributor

coopernetes commented Mar 26, 2026

@kriswest would you mind giving this an approval? I was being too helpful it seems.

New changes require approval from someone other than coopernetes because they were the last pusher.

@coopernetes
Copy link
Copy Markdown
Contributor

@finos/git-proxy-maintainers one more approval needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sub-path exports broken in published tarball — .npmignore excludes dist/src/

3 participants