Project view edge endpoints with one helper and drop repeated focus checks

[Deicyde]

Cleanup in graph_views.py. No behaviour change: 1 file, +22/-39, one commit per item.

• Edge endpoints (chapter_view, _scope_view). Each view spelled out every inside and outside combination of an edge's two ends, and repeated the boundary projection once per side. Each now projects one end in a local endpoint function and applies it to both. The skip rules are the same: chapter_view skips an edge with neither end inside the chapter, and _scope_view skips an edge whose ends are under the same child or both outside the scope, and an edge with one end outside unless include_external is set. Boundary members and edge counts are unchanged.
• Focus checks (_focus_view, _node_view). _focus_view re-checked the node id and radius that focus_view and focus_views validate before they call it. _node_view dropped duplicate and unknown ids from its selection, but both callers pass distinct ids from graph.nodes: full_view passes the mapping itself, and _focus_view passes a sorted set of ids that _adjacency has already looked up.

Noticed, not changed:

• full_view is the only caller that leaves _node_view's ordered flag off. Passing its ids in topological order would let the flag go, but Scale roadmap inventories and the full DAG explorer #90 rewrites the lines around that call.

Overlaps with open PRs:

• Scale roadmap inventories and the full DAG explorer #90 edits graph_views.py. It merges with this branch without adding a conflict, and a pyflakes and duplicate-definition check of the merged file finds nothing new.
• No other open PR edits this file.

Validation at exact head a52040da: ruff check autoform_cli servers tests is clean. tests/test_graph_views.py (8), tests/test_graph_scale.py (30), tests/test_graph_view_rendering.py (2), tests/test_hierarchy_render_regressions.py (7), tests/test_render.py (77), tests/test_visualization.py (23), tests/test_dashboard.py (14) and tests/test_skill_examples.py (25) pass.

[Deicyde]

Review at a52040d

Verdict: merge-ready. The no-behaviour-change claim holds line by line, and nothing else turned up. In chapter_view, endpoint returns an inside id unchanged and projects an outside id exactly as the old branches did. Left-to-right tuple evaluation keeps _top_scope and the boundary updates in the same order. In _scope_view, source_child == target_child covers both old skips (both None, or both under one child), because a child is a node id and never equals None. The second test then sees exactly one None end, which is the old elif not include_external case. _focus_view has no callers besides focus_view and focus_views, both of which validate node_id and radius first. Nothing in tests/, graph_pages.py or render.py calls it. Both _node_view callers pass distinct ids from graph.nodes. full_view passes the dict itself. _focus_view passes a sorted set drawn from _adjacency, which raises KeyError on any relation endpoint missing from graph.nodes before _node_view runs, and does so at head and base alike. So the dropped dict.fromkeys(... if node_id in graph.nodes) filter was a no-op. An independent fuzz run compared base and head on 240 hand-built graphs, including dangling dependencies, Node.id differing from its key, and missing statuses. Across about 25k calls to every public view, it found identical output and exceptions. Exact-head CI is green.

Landing

• Onto main 89dff279: merges cleanly. The tree for main + Share the bounded read in scaffold and the blocked exit in doctor #179 + Share the checkout-pin check between init and project new #186 + Project view edge endpoints with one helper and drop repeated focus checks #184 passes ruff check autoform_cli servers tests.
• Show finished scopes as complete, and draw containers as scopes #196 also edits graph_views.py, and Project view edge endpoints with one helper and drop repeated focus checks #184's body misses it. It adds a containers argument to _focus_view, _node_view, focus_views and full_view, but no new caller of _focus_view or _node_view, so Project view edge endpoints with one helper and drop repeated focus checks #184's premises still hold. main + Project view edge endpoints with one helper and drop repeated focus checks #184 + Show finished scopes as complete, and draw containers as scopes #196 merges cleanly and passes ruff. tests/test_graph_views.py on that tree: 8 passed.
• Scale roadmap inventories and the full DAG explorer #90 already conflicts with main. Adding Project view edge endpoints with one helper and drop repeated focus checks #184 first leaves its conflicted-file set unchanged (audit.py, mermaid.py, project/_snapshot.py), and Scale roadmap inventories and the full DAG explorer #90 adds no _node_view caller.
• Share the bounded read in scaffold and the blocked exit in doctor #179, Project view edge endpoints with one helper and drop repeated focus checks #184 and Share the checkout-pin check between init and project new #186 can land in any order.

Posted by PR swarm: Review #179 #184 #186