Repository navigation
Conversation
scaffold_project and _resolve_workflow_pin each reduced plugin_pin's answer to a safe source and a lowercase full commit, or else the default source and no commit. That rule is now _checkout_pin in scaffold.py. It still looks plugin_pin up on the scaffold module, so a test that replaces scaffold.plugin_pin still governs both commands. project/create.py imports _FULL_SHA instead of keeping its own copy.
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #96. No behaviour change: 2 files, +16/-17, one commit.
_checkout_pin(scaffold.py).autoform init(scaffold_project) andautoform project new(_resolve_workflow_pin) each reducedplugin_pin's answer the same way: a safe source and a lowercase full commit, or else the default source and no commit. The rule is now one function next toplugin_pin. It looksplugin_pinup on thescaffoldmodule, so the tests that replacescaffold.plugin_pinstill govern both commands, which is what the comment this removes fromcreate.pywas there to keep.project/create.pyimports_FULL_SHAinstead of keeping its own copy, and no longer imports thescaffoldmodule orDEFAULT_AUTOFORM_SOURCE.Noticed, not changed:
_checkout_pinonly on values they leave unchanged.Overlaps with open PRs:
scaffold.py. Each merges with this branch without adding a conflict, and a pyflakes and duplicate-definition check of the merged files finds nothing new.Validation at exact head
aa06d4ed:ruff check autoform_cli servers testsis clean.tests/test_project_create.py(257),tests/test_scaffold.py(106),tests/test_render.py(77),tests/test_project_inspect.py(272) andtests/test_cli.py(5) pass.