Skip to content

Use _refused in the remaining refusal tests and drop a dead hash-length branch #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Deicyde merged 2 commits into from
Oct 7, 2026
Merged

Use _refused in the remaining refusal tests and drop a dead hash-length branch #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33e92ca
Use _refused in the last three refusal tests
Deicyde Oct 6, 2026
553d79c
Drop the unreachable hash-length branch in _git_blob_id
Deicyde Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions autoform_cli/scaffold.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,9 +355,7 @@ def _committed_scaffold_entries(


def _git_blob_id(content: bytes, length: int) -> str | None:
algorithm = {40: "sha1", 64: "sha256"}.get(length)
if algorithm is None:
return None
algorithm = {40: "sha1", 64: "sha256"}[length]
try:
digest = hashlib.new(algorithm, usedforsecurity=False)
except ValueError:
Expand Down
20 changes: 3 additions & 17 deletions tests/test_project_create.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,11 +424,7 @@ def test_open_parent_descriptor_rechecks_the_generated_module_filename_limit(


def test_rejects_unknown_release_before_writing(tmp_path: Path) -> None:
target = tmp_path / "project"
with pytest.raises(ProjectCreateError) as raised:
create_project(target, package="Project", release_id="unknown")
assert raised.value.code == "project-release-unknown"
assert not target.exists()
_refused(tmp_path / "project", "project-release-unknown", release_id="unknown")


def test_omitted_release_uses_the_recommended_release(tmp_path: Path) -> None:
Expand Down Expand Up @@ -840,12 +836,7 @@ def corrupt(*args, **kwargs):

monkeypatch.setattr(create_module, "_build_project_plan", corrupt)

with pytest.raises(ProjectCreateError) as raised:
create_project(target, package="Project", release_id=_RELEASE)

assert raised.value.code == "project-create-validation-failed"
assert not target.exists()
assert not list(tmp_path.glob(".autoform-new-*"))
_refused(target, "project-create-validation-failed")


@pytest.mark.parametrize("corruption", ["container", "relative", "content", "mode"])
Expand Down Expand Up @@ -1719,12 +1710,7 @@ def test_group_writable_parent_is_refused_with_a_remedy(tmp_path: Path) -> None:
parent.mkdir(mode=0o700)
parent.chmod(0o775)

with pytest.raises(ProjectCreateError) as raised:
create_project(parent / "Project", package="Project", release_id=_RELEASE)

assert raised.value.code == "project-parent-unsafe"
assert "chmod g-w,o-w" in raised.value.message
assert not list(parent.iterdir())
assert "chmod g-w,o-w" in _refused(parent / "Project", "project-parent-unsafe").message


_NEEDS_PERMISSIONS = pytest.mark.skipif(
Expand Down
Loading