Repository navigation
Use _refused in the remaining refusal tests and drop a dead hash-length branch - #162
Merged
Merged
Conversation
These tests repeated _refused's checks by hand. Its unchanged-parent assertion also covers the absent target and the empty stage glob they asserted.
Its only caller passes the length of an object ID that _committed_scaffold_entries has already matched against 40 or 64 hex digits. The hashlib.new ValueError fallback stays; test_plugin_pin_is_empty_when_git_digests_are_unavailable pins it.
Deicyde
marked this pull request as ready for review
October 6, 2026 06:42
Contributor
Author
|
Exact-head review at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #152 and #153, from the post-merge notes on each (#152 comment 6010274834, #153 comment 6010275110).
test_rejects_unknown_release_before_writing,test_invalid_planned_roadmap_is_never_publishedandtest_group_writable_parent_is_refused_with_a_remedyrepeated_refused's checks by hand. They now call it. Each keeps its error code and message assertions, and_refused's unchanged-parent check covers the absent target and the empty stage glob they asserted._git_blob_id(-2 lines). Its only caller passes the length of an object ID that_committed_scaffold_entrieshas already matched against 40 or 64 hex digits (scaffold.py:339), so the unknown-length branch could not run. Thehashlib.newValueErrorfallback stays;test_plugin_pin_is_empty_when_git_digests_are_unavailablepins it.Left out: the other #153 note, routing the mode string at
scaffold.py:399through_canonical_template_mode. It saves no lines, and the inline expression reads more clearly.This still merges cleanly with #151 at its repaired head
e0f31f26, although both edit the same test file.Validation at exact head
553d79c2: Ruff is clean; the three changed tests pass;tests/test_scaffold.py -k pinpasses (22); all 9 GitHub checks pass, including both real-Lean and Windows jobs. The exact-head agent audit found no blocker; human GitHub review is pending.