Repository navigation
Add module apis for watching for deviceId - #35741
Merged
Merged
Conversation
t3chguy
requested changes
Nov 9, 2026
t3chguy
left a comment
Member
There was a problem hiding this comment.
I think this is a bad idea. Token TTL default in MAS is 5 minutes. Which makes it rather likely that a token you read ends up expiring rather soon and you have to handle refresh. Your proposed API returns strings, not Watchables, and making all Modules respect token refresh would be spurious additional work which could be done on this side of the fence with a better API.
Moving to a separate PR as doAuthenticatedRequest.
9 tasks
t3chguy
approved these changes
Nov 9, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3 common things we do in modules that probably should just get their own API. Unsure whether we should slap some warnings on these that they may break when multi-account comes in?Removed the access token because it was controversial . Given the userId is already exposed as a watchable under Profile, I've cheekily included deviceId too rather than adding it under it's own thing.
Checklist
public/exportedsymbols have accurate TSDoc documentation.AI assistance