Repository navigation
Conversation
Half-Shot
added
the
T-Feature
Half-Shot
added
T-Enhancement
and removed
T-Feature
t3chguy
reviewed
Nov 9, 2026
Comment on lines
+40
to
+51
| const token = MatrixClientPeg.safeGet().getAccessToken(); | ||
| if (!token) { | ||
| throw new Error("Client has no token. Refusing to make request"); | ||
| } | ||
|
|
||
| const request = new Request(input, init); | ||
| const headers = new Headers(request.headers); | ||
| if (headers.has("Authorization")) { | ||
| throw new Error("Request already has an Authorization header. Refusing to make request"); | ||
| } | ||
| headers.set("Authorization", `Bearer ${token}`); | ||
| return fetch(new Request(request, { headers })); |
Member
There was a problem hiding this comment.
The point of doing this on this side of the fence was to reuse the js-sdk's support for token refresh - otherwise you run into the same issue with the 5 minute default TTL in MAS
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative take on
getAccessToken/ what #35741 originally did which avoids exposing the access token directly to the module.This exposes a function that passes in the user's current access token into
fetch. There are two variantsdoAuthenticatedRequestanddoUnsafeAuthenticatedRequestwhich allows the module to either make a request at the homeserver, or (with a large warning block) make a request to any domain. The latter is necessary for resources not hosted on the same domain as the homeserver.Checklist
public/exportedsymbols have accurate TSDoc documentation.AI assistance