Skip to content

Add toggle_visible to the native omnibar-shown pixel - #9479

Merged
YoussefKeyrouz merged 2 commits into
developfrom
feature/youssef/measure_exposure_unified_input
Aug 19, 2026
Merged

Add toggle_visible to the native omnibar-shown pixel#9479
YoussefKeyrouz merged 2 commits into
developfrom
feature/youssef/measure_exposure_unified_input

Conversation

@YoussefKeyrouz

@YoussefKeyrouz YoussefKeyrouz commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1217295011063286?focus=true
Tech Design URL (if applicable):
API Proposals URL(s) (if applicable):

Description

Description

Adds a toggle_visible parameter to m_aichat_experimental_omnibar_shown
We fire a pixel whenever the native Input Screen is shown, but can't yet tell what fraction of those
impressions actually offered the Search/Duck.ai toggle. This adds one param:

Pixel Added
m_aichat_experimental_omnibar_shown / _count toggle_visible

toggle_visible is a boolean, reusing the same DuckChatInternal.resolvedTogglePosition() != null
check used in other pixels pixel.

Steps to test this PR

Enable the nativeInputField and nativeInputSearchOnly feature flag, attach logcat, filter for Pixel sent:.

toggle_visible on the native Input Screen

  • With Search + Duck.ai enabled (toggle offered), open the Input Screen —
    m_aichat_experimental_omnibar_shown_count carries toggle_visible=true
  • Turn Search + Duck.ai off so no toggle is offered, open the Input Screen again ->
    toggle_visible=false

UI changes

No UI changes


Note

Low Risk
Analytics-only pixel parameter and wiring; no user-facing behavior or security-sensitive paths.

Overview
Adds toggle_visible to the pixel definitions for m_aichat_experimental_omnibar_shown and m_aichat_experimental_omnibar_shown_count, so analytics can split native input impressions by whether the Search/Duck.ai toggle was on screen.

fireOmnibarShown() now passes toggle_visible on both count and daily fires, derived from DuckChatInternal.resolvedTogglePosition() != null. RealDuckChatPixels takes DuckChatInternal as a new constructor dependency.

Tests were updated to supply the mock internal API, and RealDuckChatPixelsTest now asserts toggle_visible=true vs false for the two toggle cases.

Reviewed by Cursor Bugbot for commit 4bd21d6. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

Privacy Review task: https://app.asana.com/0/69071770703008/1217448037272161

@karlenDimla karlenDimla self-assigned this Aug 13, 2026
@YoussefKeyrouz
YoussefKeyrouz force-pushed the feature/youssef/duckai_default_mode_pixel_param branch from 4df9d5e to c915451 Compare August 16, 2026 10:43
@YoussefKeyrouz
YoussefKeyrouz force-pushed the feature/youssef/measure_exposure_unified_input branch from a9de642 to f54ff6c Compare August 16, 2026 10:43
@YoussefKeyrouz
YoussefKeyrouz force-pushed the feature/youssef/measure_exposure_unified_input branch from f54ff6c to 1025f5e Compare August 17, 2026 17:55
@YoussefKeyrouz
YoussefKeyrouz force-pushed the feature/youssef/duckai_default_mode_pixel_param branch from 5a49c9e to c57bbe5 Compare August 17, 2026 19:00
@YoussefKeyrouz
YoussefKeyrouz force-pushed the feature/youssef/measure_exposure_unified_input branch from 1025f5e to a9e17c5 Compare August 17, 2026 19:00

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a9e17c5. Configure here.

@YoussefKeyrouz
YoussefKeyrouz force-pushed the feature/youssef/duckai_default_mode_pixel_param branch from c57bbe5 to fd1766d Compare August 18, 2026 20:02
@YoussefKeyrouz
YoussefKeyrouz force-pushed the feature/youssef/measure_exposure_unified_input branch from a9e17c5 to 5e38d86 Compare August 18, 2026 20:02
@YoussefKeyrouz
YoussefKeyrouz force-pushed the feature/youssef/duckai_default_mode_pixel_param branch from fd1766d to ee8d10a Compare August 18, 2026 22:06
@YoussefKeyrouz
YoussefKeyrouz force-pushed the feature/youssef/measure_exposure_unified_input branch 2 times, most recently from 44612f1 to dac42dc Compare August 18, 2026 23:04
Base automatically changed from feature/youssef/duckai_default_mode_pixel_param to develop August 18, 2026 23:25
@YoussefKeyrouz
YoussefKeyrouz force-pushed the feature/youssef/measure_exposure_unified_input branch from dac42dc to 4bd21d6 Compare August 19, 2026 03:06
@YoussefKeyrouz
YoussefKeyrouz added this pull request to the merge queue Aug 19, 2026
Merged via the queue into develop with commit 7682a2c Aug 19, 2026
21 checks passed
@YoussefKeyrouz
YoussefKeyrouz deleted the feature/youssef/measure_exposure_unified_input branch August 19, 2026 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants