Add toggle_visible to the native omnibar-shown pixel - #9479
Merged
YoussefKeyrouz merged 2 commits intoAug 19, 2026
Conversation
Collaborator
Author
15 tasks
Contributor
|
Privacy Review task: https://app.asana.com/0/69071770703008/1217448037272161 |
karlenDimla
approved these changes
Aug 13, 2026
YoussefKeyrouz
force-pushed
the
feature/youssef/duckai_default_mode_pixel_param
branch
from
August 16, 2026 10:43
4df9d5e to
c915451
Compare
YoussefKeyrouz
force-pushed
the
feature/youssef/measure_exposure_unified_input
branch
from
August 16, 2026 10:43
a9de642 to
f54ff6c
Compare
16 tasks
YoussefKeyrouz
force-pushed
the
feature/youssef/measure_exposure_unified_input
branch
from
August 17, 2026 17:55
f54ff6c to
1025f5e
Compare
YoussefKeyrouz
force-pushed
the
feature/youssef/duckai_default_mode_pixel_param
branch
from
August 17, 2026 19:00
5a49c9e to
c57bbe5
Compare
YoussefKeyrouz
force-pushed
the
feature/youssef/measure_exposure_unified_input
branch
from
August 17, 2026 19:00
1025f5e to
a9e17c5
Compare
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a9e17c5. Configure here.
5 tasks
YoussefKeyrouz
force-pushed
the
feature/youssef/duckai_default_mode_pixel_param
branch
from
August 18, 2026 20:02
c57bbe5 to
fd1766d
Compare
YoussefKeyrouz
force-pushed
the
feature/youssef/measure_exposure_unified_input
branch
from
August 18, 2026 20:02
a9e17c5 to
5e38d86
Compare
YoussefKeyrouz
force-pushed
the
feature/youssef/duckai_default_mode_pixel_param
branch
from
August 18, 2026 22:06
fd1766d to
ee8d10a
Compare
YoussefKeyrouz
force-pushed
the
feature/youssef/measure_exposure_unified_input
branch
2 times, most recently
from
August 18, 2026 23:04
44612f1 to
dac42dc
Compare
Base automatically changed from
feature/youssef/duckai_default_mode_pixel_param
to
develop
August 18, 2026 23:25
YoussefKeyrouz
force-pushed
the
feature/youssef/measure_exposure_unified_input
branch
from
August 19, 2026 03:06
dac42dc to
4bd21d6
Compare
YoussefKeyrouz
deleted the
feature/youssef/measure_exposure_unified_input
branch
August 19, 2026 03:58
This was referenced Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1217295011063286?focus=true
Tech Design URL (if applicable):
API Proposals URL(s) (if applicable):
Description
Description
Adds a toggle_visible parameter to
m_aichat_experimental_omnibar_shownWe fire a pixel whenever the native Input Screen is shown, but can't yet tell what fraction of those
impressions actually offered the Search/Duck.ai toggle. This adds one param:
m_aichat_experimental_omnibar_shown/_counttoggle_visibletoggle_visibleis a boolean, reusing the sameDuckChatInternal.resolvedTogglePosition() != nullcheck used in other pixels pixel.
Steps to test this PR
Enable the
nativeInputFieldandnativeInputSearchOnlyfeature flag, attach logcat, filter forPixel sent:.toggle_visible on the native Input Screen
m_aichat_experimental_omnibar_shown_countcarriestoggle_visible=truetoggle_visible=falseUI changes
No UI changes
Note
Low Risk
Analytics-only pixel parameter and wiring; no user-facing behavior or security-sensitive paths.
Overview
Adds
toggle_visibleto the pixel definitions form_aichat_experimental_omnibar_shownandm_aichat_experimental_omnibar_shown_count, so analytics can split native input impressions by whether the Search/Duck.ai toggle was on screen.fireOmnibarShown()now passestoggle_visibleon both count and daily fires, derived fromDuckChatInternal.resolvedTogglePosition() != null.RealDuckChatPixelstakesDuckChatInternalas a new constructor dependency.Tests were updated to supply the mock internal API, and
RealDuckChatPixelsTestnow assertstoggle_visible=truevsfalsefor the two toggle cases.Reviewed by Cursor Bugbot for commit 4bd21d6. Bugbot is set up for automated code reviews on this repo. Configure here.