Report Duck.ai capability state on the daily feature-state pixel - #9465
Merged
YoussefKeyrouz merged 2 commits intoAug 18, 2026
Merged
Conversation
Collaborator
Author
Contributor
|
Privacy Review task: https://app.asana.com/0/69071770703008/1217380986937115 |
YoussefKeyrouz
force-pushed
the
feature/youssef/duckai_capability_state_pixel
branch
from
August 11, 2026 19:17
4aba33b to
8d8b148
Compare
This was referenced Aug 12, 2026
YoussefKeyrouz
force-pushed
the
feature/youssef/duckai_capability_state_pixel
branch
from
August 16, 2026 10:43
8d8b148 to
43e0447
Compare
16 tasks
YoussefKeyrouz
force-pushed
the
feature/youssef/duckai_capability_state_pixel
branch
from
August 17, 2026 19:00
43e0447 to
b01daee
Compare
malmstein
approved these changes
Aug 17, 2026
malmstein
left a comment
Contributor
There was a problem hiding this comment.
Reviewed statically, telemetry only.
The definition file is the standout: it retro-documents m_browser_feature_daily_active_user_d, which had none. Audited it against every contributor and it is exact, no plugin missing, nothing documented that is not sent, and both enums match the emitted strings (TOP/BOTTOM/SPLIT_TOP from OmnibarType.typeName, new_tab_page/last_opened_tab/specific_page from getDailyPixelValue). The new plugin follows the existing shape and all three params are bounded with no PII.
One question inline on capability read timing, since its default is also a valid value.
5 tasks
YoussefKeyrouz
force-pushed
the
feature/youssef/duckai_capability_state_pixel
branch
from
August 18, 2026 20:02
b01daee to
344781c
Compare
YoussefKeyrouz
deleted the
feature/youssef/duckai_capability_state_pixel
branch
August 18, 2026 22:04
This was referenced Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1217295011063282?focus=true
Tech Design URL (if applicable): https://app.asana.com/1/137249556945/project/1212810093780571/task/1217382844057496?focus=true
API Proposals URL(s) (if applicable):
Description
Extends
m_browser_feature_daily_active_user_dthe pixel we already send once a day per activeuser with each module's feature state — to include Duck.ai, which contributed nothing to it. Three
new params:
duck_ai_input_modesearch_and_duck_ai/search_onlyduck_ai_native_input1/0duck_ai_contextual1/0Note
Low Risk
Read-only analytics on an existing daily pixel pattern; no auth, payments, or user data handling changes.
Overview
Extends the daily
m_browser_feature_daily_active_user_dpixel so Duck.ai contributes three new parameters:duck_ai_input_mode(search_and_duck_aivssearch_only),duck_ai_native_input, andduck_ai_contextual.A new
DuckAiFeatureStateReporterPluginregisters with the existingBrowserFeatureStateReporterPluginmultibinding. Input mode is derived from Duck Chat feature toggles and repository settings; native input and contextual flags come fromDuckAiFeatureState. Pixel definitions inbrowser_feature_state.json5document the enums, and unit tests cover off/on states and independence of input mode from the native input surface.Reviewed by Cursor Bugbot for commit 344781c. Bugbot is set up for automated code reviews on this repo. Configure here.