Skip to content

doveadm: client-connection-tcp - Don't read past args in flag loop #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nishat-06 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

doveadm: client-connection-tcp - Don't read past args in flag loop #300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/doveadm/client-connection-tcp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,11 @@ static bool client_handle_command_ctx(struct client_connection_tcp *conn,
doveadm_verbose = TRUE;
break;
case DOVEADM_PROTOCOL_CMD_FLAG_EXTRA_FIELDS:
if (argc == 0) {
e_error(cctx->event, "doveadm client: "
"Missing extra fields argument");
return FALSE;
}
cctx->extra_fields = t_strsplit_tabescaped(args[0]);
args++; argc--;
break;
Expand All @@ -299,6 +304,10 @@ static bool client_handle_command_ctx(struct client_connection_tcp *conn,
return FALSE;
}
}
if (argc < 2) {
e_error(cctx->event, "doveadm client: No command given");
return FALSE;
}
cctx->username = args[0]; args++; argc--;
cmd_name = args[0];

Expand Down