doveadm: client-connection-tcp - Don't read past args in flag loop#300
Open
nishat-06 wants to merge 1 commit into
Open
doveadm: client-connection-tcp - Don't read past args in flag loop#300nishat-06 wants to merge 1 commit into
nishat-06 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
client_handle_command_ctx() checks argc>=3 once, before the flag loop, but each 'x' (extra-fields) flag then consumes an args slot with no further check, and the username and command name take two more after it. A doveadm command line whose flag field holds more flag-consumers than there are following arguments makes args walk past the NULL terminator of the t_strsplit_tabescaped() array: with flags "xx" on a three-field line, cmd_name = args[0] reads one entry past the array and argc underflows to UINT_MAX before it reaches doveadm_cmd_handle(). Re-check argc before taking the extra-fields argument and before reading the username and command name.