fix(org-switcher): give the create-organization icon button an accessible name - #6903
Closed
pedrofrxncx wants to merge 1 commit into
Closed
fix(org-switcher): give the create-organization icon button an accessible name#6903pedrofrxncx wants to merge 1 commit into
pedrofrxncx wants to merge 1 commit into
Conversation
…ible name The + button that opens the create-organization dialog inside the org switcher popover rendered only a Plus icon with no aria-label, text, or title — a screen reader announces it as an unlabeled button, so keyboard/AT users can't tell what it does.
Collaborator
Author
|
Closing as stale: this PR sat past the bot's 48h merge window, main has moved on, and its CI results no longer reflect the current base. This is a housekeeping close, not a rejection of the change — if the underlying problem still exists, the bot will find it again and open a fresh, rebased PR. [studio-bot:stale-close] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The org switcher popover (
apps/web/src/components/header/org-switcher.tsx, used by both the sidebar-footer account popover and the toolbar org breadcrumb) renders a+button that opens the create-organization dialog. It has noaria-label, no visible text, and notitle— only aPlusicon glyph — so a screen reader announces it as an unlabeledbutton, and there's no accessible way for AT users to know it creates an organization.Fix: add
header.orgSwitcher.createOrganization("Create organization" / "Criar organização") to the en/pt-br header dictionaries and wire it as the button'saria-label, matching the existing pattern used by every other icon-only control in the same file (e.g. the invitation-declineXClosebutton already has one).How to verify:
cd apps/web && bunx tsc --noEmit(clean on the touched files) and inspect the accessible name of the+button in the org switcher popover (org icon in the sidebar header or toolbar breadcrumb → click to open → the+icon button top-right of the search bar) — it now reads "Create organization" instead of being unlabeled.Locally ran:
bun run fmt,cd apps/web && bunx tsc --noEmit(no new errors — the one pre-existing prosemirror version-mismatch error is unrelated to these files),bunx oxlinton the three touched files (0 warnings/errors). No unit test added — this is a static aria-label fix with no branching logic to exercise; full CI covers the rest.Summary by cubic
Gives the create-organization button in the org switcher an accessible name so screen readers announce it as "Create organization" instead of an unlabeled button. Adds the label to the en and pt-br header dictionaries.
Written for commit 8ab36f0. Summary will update on new commits.