fix(preview): expose the page selector's open/closed state to screen readers - #6960
Merged
Merged
Conversation
…readers The chevron button that toggles the CMS page-selector popover had an aria-label but no aria-expanded, so a screen reader user got no signal that activating it opens/closes a popover, or which state it's currently in.
pedrofrxncx
enabled auto-merge (squash)
September 3, 2026 23:00
decocms Bot
pushed a commit
that referenced
this pull request
Sep 3, 2026
![decocms-release[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
PR: #6960 fix(preview): expose the page selector's open/closed state to screen readers Bump type: patch - decocms (apps/api/package.json): 4.328.3 -> 4.328.4 - @decocms/native (apps/native/package.json): 4.328.3 -> 4.328.4 Deploy-Scope: web
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source: a11y gap found while auditing
apps/web/src/components/sandbox/preview/preview.tsx(sandbox preview components focus area) — the recent site-editor toolbar rework (#6943/#6946/#6947) touched this file without adding it.Payoff: the chevron button that opens/closes the CMS page-selector popover (page name +
:paraminputs + "Create page") hadaria-labelbut noaria-expanded, so a screen-reader user got no indication the control is a disclosure toggle or which state it's in — the same gap this repo has fixed repeatedly for other toggles (#6884, #6895, #6902, #6903).Fix: add
aria-expanded={pagesOpen}to the toggle button, mirroring the existing pattern inpage-template-select.tsxand other disclosure buttons in the codebase.Verify: open Preview on a deco-framework repo, inspect the page-selector chevron button in devtools —
aria-expandedshould flip betweenfalse/trueas the popover opens/closes.Checks run locally:
bun run fmt,cd apps/web && bunx tsc --noEmit(zero errors touching this file — the one pre-existing error is an unrelated prosemirror version-hoisting conflict inmention-suggestion.tsx),bunx oxlint apps/web/src/components/sandbox/preview/preview.tsx(0 warnings/errors). No test added — a one-line ARIA attribute on an existing toggle isn't independently testable logic; full CI covers the rest.Summary by cubic
Adds
aria-expandedto the page-selector chevron button so screen readers announce whether the popover is open or closed. Previously the button only had anaria-label, giving no indication that it toggles a disclosure.Written for commit 2647dcf. Summary will update on new commits.