Skip to content

Allow symlinked image frames in embedded viewer previews #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sarlinpe wants to merge 1 commit into from
+1 −3
Open

Allow symlinked image frames in embedded viewer previews #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions vidmap/visualization/html/embedded.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,7 @@ def _embed_image_previews(
normalized_name = name.replace("\\", "/")
if normalized_name.startswith("/") or ".." in normalized_name.split("/"):
raise ValueError(f"Reconstruction image name is not a safe relative path: {name}")
image_path = (resolved_images_dir / normalized_name).resolve()
if not image_path.is_relative_to(resolved_images_dir):
raise ValueError(f"Reconstruction image name escapes the image directory: {name}")
image_path = resolved_images_dir / normalized_name
if not image_path.is_file():
raise FileNotFoundError(f"Timeline image does not exist: {image_path}")
with Image.open(image_path) as source:
Expand Down
Loading