Repository navigation
Conversation
sarlinpe
added this pull request to stack #43
October 9, 2026 15:45
sarlinpe
force-pushed
the
fix/viewer-symlink-previews
branch
from
October 10, 2026 00:07
9a2f3b1 to
1c13033
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Embedded viewer previews rejected image directories whose frames are symlinks (e.g. a run whose
video_frames/points to frames decoded elsewhere): the path was resolved and then required to stay inside the image directory. Keep the check that image names are safe relative paths (no absolute paths, no..), but do not resolve symlinks.