Repository navigation
Fix loading saved evaluation results and script exit codes - #24
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For items 1 and 2 of #23; item 3 is left open there.
SparseEvalResult.load_from_npyrebuildsControlPointSummaryobjects from the dicts written bysave_as_npy, so the metric functions work on a reloaded result.evaluate_wrt_control_points.py,evaluate_wrt_pgt.pyandevaluate_wrt_mps.pyexit with status 1 whenrun()returnsFalse.Tested on
sequence_1_19from the demo, with the pinned pycolmap/pyceres on Linux:evaluate_wrt_pgt.pyrecalls unchanged).evaluate_wrt_control_points.pyand reloaded withload_from_npygives the same score and recall as the in-memory result.--sparse_eval_result); successful runs exit 0.evaluate_wrt_mps.pyhas the same change but was not run, as I don't have MPS data for the demo.format.shwith ruff 0.12.7 reports no changes.