Conversation
This was referenced Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Layer 2 of the Shadcn stack (base: the brand-theme PR). Introduces the Elm-consistent transient-notice boundary and uses it for the first event (reader settings saved).
shared/notice.dart:Notice/NoticeKindvalue data (no closures).shared/sonner_bridge.dart:SonnerBridge, a view-layer adapter that observes the immutable model, presents aShadToastexactly once per notice id, and reports back via a consumption callback. It never mutates model state.LibraryModelgains a nullablenotice;LibraryControllerraises a success notice on settings save and clears it onLibraryNoticeConsumed.ProductShellwraps its scaffold inSonnerBridge.This layer keeps the existing retry banners untouched; the next layers migrate the banners to toasts.
Testing
SonnerBridgepresents a notice once and reports consumption.make test-flutter(284),make lint-flutter,make check-fmt-flutter.Stack
ShadSheet/ShadTabsresponsive surfacesShadContextMenu/ShadBadge/ShadSeparator