Conversation
This was referenced Sep 14, 2026
Member
Author
|
Closing with owner approval as superseded by the Flutter UI restoration plan in docs/flutter-ui-restoration-plan.md (reference tooling landed in #117). This is not a claim that the Flutter replacement is already implemented. The branch is being preserved so useful work remains available. The library-tab visual direction is superseded by Stage 3: wide sidebar and compact filter navigation, retaining CBZ and directly accessible Settings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Layer 6 of the Shadcn stack (base: the reader toasts). Replaces the library's format filter buttons with a real
ShadTabspage: the format tabs own the collection content.All/PDF/EPUB/CBZare nowShadTabs; selecting one dispatchesLibraryFormatChangedexactly as before.maintainState: falseso only the active collection is built (a non-selectedShadTabcontent is otherwise laid out withoutExpanded, which leaves aGridViewunbounded), andscrollable: trueso the bar doesn't overflow at 2× text scale and narrow widths.No controller or model changes; this is presentation only.
Testing
make test-flutter(284),make lint-flutter,make check-fmt-flutter.reader settings remain scrollable,compact Japanese library at 200%,long multilingual metadata) pass via the scrollable tab bar.Stack
ShadContextMenu/ShadBadge/ShadSeparator