Repository navigation
BUZZ-271: Bound live-session revalidation - #8241
Draft
bradseiler wants to merge 14 commits into
Draft
bradseiler wants to merge 14 commits into
bradseiler wants to merge 14 commits into
Conversation
Signed-off-by: seiler <seiler@squareup.com> Co-authored-by: Codex <noreply@openai.com> (cherry picked from commit 92f13229ed3038d63f2a2d9c889bfd4c212e38e2) Signed-off-by: Brad Seiler <seiler@squareup.com>
Restore CommunityDisconnectReason near the top of state.rs and document scan deadline and reconnect-load limitations. Authorization behavior is unchanged. Signed-off-by: seiler <seiler@squareup.com> Co-authored-by: Codex <noreply@openai.com> (cherry picked from commit a4d1ab288d761d44eba25cc62d25b7d2858788dc) Signed-off-by: Brad Seiler <seiler@squareup.com>
Authenticate through root and audio handlers before a durable-only ban. Removing either production enrollment call must fail its regression. Co-authored-by: Codex <noreply@openai.com> Signed-off-by: Brad Seiler <seiler@squareup.com>
Co-authored-by: Codex <codex@openai.com> Signed-off-by: Brad Seiler <seiler@squareup.com>
Co-authored-by: Codex <codex@openai.com> Signed-off-by: Brad Seiler <seiler@squareup.com>
Complete the preserved 66663e19 remediation with a deterministic production-consumer regression, cancellation-safety documentation, and deadline diagnostics. Original recovered refs and their attribution remain unchanged. Co-authored-by: Codex <codex@openai.com> Signed-off-by: Brad Seiler <seiler@squareup.com> (cherry picked from commit f1674a2) Signed-off-by: Brad Seiler <seiler@squareup.com>
Co-authored-by: Codex <codex@openai.com> Signed-off-by: Brad Seiler <seiler@squareup.com> (cherry picked from commit 3d02a44) Signed-off-by: Brad Seiler <seiler@squareup.com>
Co-authored-by: Codex <codex@openai.com> Signed-off-by: Brad Seiler <seiler@squareup.com> (cherry picked from commit d43b957) Signed-off-by: Brad Seiler <seiler@squareup.com>
Exercise signed root and audio admission against an isolated running relay, durable direct-member and owner bans, a responsive bystander, and bounded database-failure closure. Co-authored-by: Codex <codex@openai.com> Signed-off-by: Brad Seiler <seiler@squareup.com>
Co-authored-by: Codex <codex@openai.com> Signed-off-by: Brad Seiler <seiler@squareup.com>
…cture Co-authored-by: Codex <codex@openai.com> Signed-off-by: Brad Seiler <seiler@squareup.com>
Co-authored-by: Codex <codex@openai.com> Signed-off-by: Brad Seiler <seiler@squareup.com>
Avoid comparing host and PostgreSQL clocks in the async enqueue guard regression. Assert strict lease ordering before releasing activation. Co-authored-by: Codex <noreply@openai.com> Signed-off-by: Brad Seiler <seiler@squareup.com> (cherry picked from commit 893f81f) Signed-off-by: Brad Seiler <seiler@squareup.com>
Keep a clear audio participant present through policy eviction so the huddle remains active for the database-failure phase. Reject bare closes with a labeled diagnostic. Co-authored-by: Codex <noreply@openai.com> Signed-off-by: Brad Seiler <seiler@squareup.com>
This was referenced Oct 10, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Close admitted root and huddle-audio sockets when durable community bans or membership changes are missed by Redis delivery. Revalidate direct members and verified owner-linked agents against PostgreSQL with bounded batches, concurrency, deadlines, and a fail-closed database-error grace period.
Fence refreshes against current membership and owner state so stale results cannot keep or restore access. Enroll sockets through the real admission paths and start the periodic worker from relay main. Community timeouts retain their existing session policy.
This draft includes the shared mesh receive fix needed for independent validation.
Related issue
BUZZ-271. Companion invitation replacement: #8237. Staging verification runbook: #8235. Regression coverage: #8239.
Testing
Validated
541284c1c67f16e30d7c8d52f57ed2965919797e: full DB/relay packages and doctests passed; the complete discovered PostgreSQL suite passed 941/941; a freshly built relay passed the separate live rehearsal.Full repository
just ciandjust testpassed on that same head.The first normal push failed an unchanged composition logging fixture because its expected library warning was absent from captured output. Independent review found no candidate-caused defect; concurrent tracing-filter interference is plausible but unproven. The complete binary suite passed serially (34 passed, 1 ignored), and the full normal hook retry passed with one Rust test worker on the unchanged source head. No hooks or checks were bypassed.
Ordinary repository lanes retain configured infrastructure skips; the separate PostgreSQL suite uses isolated services. Existing ACP pipe-test leak warnings were reported with passing exit status.
Real root/audio admission PostgreSQL regressions pass; removing either production enrollment call makes the corresponding test fail. The separate-relay live rehearsal closed four root/audio member and owner-linked-agent sockets with policy code 1008 within 3.491 seconds of DB-only bans. It closed the two clear root/audio sockets within 9.997 seconds of restriction lookup failure. No Redis notification was published; the clear bystander remained responsive before the failure phase. Its agent fixture exercises owner-derived relay admission on both routes; a clear audio participant keeps the huddle active through the eviction and database-failure phases.
Independent agent review found no remaining blockers. Draft only: human testing and hosted cross-pod evidence remain outstanding.
Hosted CI on this head has an outstanding Desktop Smoke E2E shard 4 failure: the non-empty message-edit test failed all three attempts, causing both desktop summary checks to fail. Independent assessment found this unrelated to the relay/DB change: the desktop tree and smoke workflow match main, and this test edits an in-memory mock store without executing production Rust. Its root cause remains uncategorized. This draft does not claim all hosted required checks are green.
Companion drafts
Webhook owner policy: BUZZ-272.
Generated with Codex.