Repository navigation
fix(sdk): preserve undefined successful batch results - #982
Merged
zhongkechen merged 4 commits intoOct 15, 2026
Merged
Conversation
zhongkechen
approved these changes
Oct 14, 2026
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue Link, if available
Fixes #979
Description
BatchResult.succeeded()andfailed()required both a matching status and a defined value. A successful branch returningundefinedwas therefore omitted:succeeded().lengthcould disagree withsuccessCount, andgetResults()lost the branch's position.Filter the real and mock batch views by status.
getResults()andgetErrors()continue to map those views. This changes no public type or unrelated handler logic.For failure results, the existing live and replay builders attach a
ChildContextErrorto eachFAILEDitem. An artificially constructedFAILEDitem without an error is outside that observed construction path. This PR does not redefinethrowIfError()or broaden the public error type for that input.Demo/Screenshots
Not applicable to this SDK behavior change.
Checklist
Testing
Unit Tests
batch-result.test.ts: 19/19 pass; these tests are included in the core suite.tsc --noEmit, Biome on 200 core files, andgit diff --checkpass.Integration Tests
Examples
No example was added; this is a bug fix without a new feature or public API type change.