Repository navigation
test: cover OTel replay and user function contexts - #960
Open
zhongkechen wants to merge 31 commits into
Open
zhongkechen wants to merge 31 commits into
zhongkechen wants to merge 31 commits into
Conversation
zhongkechen
requested a deployment
to
ai-pr-review-runtime
October 2, 2026 23:58 — with
GitHub Actions
Waiting
This comment has been minimized.
This comment has been minimized.
zhongkechen
had a problem deploying
to
ai-pr-review-runtime
October 3, 2026 01:54 — with
GitHub Actions
Error
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
zhongkechen
had a problem deploying
to
ai-pr-review-runtime
October 6, 2026 19:23 — with
GitHub Actions
Failure
zhongkechen
had a problem deploying
to
ai-pr-review-runtime
October 6, 2026 22:23 — with
GitHub Actions
Failure
added 5 commits
October 6, 2026 23:27
Codex AI reviewNo actionable findings. Residual risk remains in the untested successful download/extraction and arm64 paths of the new Node bootstrap script. Reviewed commit |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add public SDK handlers for OTel cases 21–24: completed-operation replay, active context in user functions/callbacks, and invocation retry status. Ordinary user spans inherit their active parent; handlers do not attach replacement context or invoke plugin hooks. Both views execute the same workflow code.
Pin shared requirements aws/aws-durable-execution-conformance-tests#131 to
6182cee00ed33ce01e0579066fb31096f988817f. Case 24 checks exactly RETRYING then SUCCEEDED, optionally with one canonical PENDING suspension for the public step retry delay between them. Counts, first flags, span status, ordering, full Invocation coverage and a five-second stability window reject incorrect or extra phases; expected operation redelivery after invocation failure remains allowed. Cases cover handler entry/restoration/resume, steps, child contexts, parallel/map branches, polling predicates, callback submitters, retry helpers and virtual contexts. The shared coverage matrix documents initialization, policy, serialization and application-created thread boundaries that lack an active SDK-operation-span contract.Runtime prerequisites included here are replay #953, local invocation wrapper #954, clock #962 and polling continuation links #964; CI repair #959 is also included. Merge those and the shared requirements first, with #954 before #953, then update this branch from main to remove their shared diffs. No plugin API or factory-lifetime migration is introduced.
The replay fix exports externally completed operations even when workflow code defers reading the result until after another suspension. Both views collect current-invocation updates, export fresh pending completions during traversal even when the SDK marks them replay, and drain remaining unobserved completions before cleanup. This retains an active child parent and deduplicates within the invocation. Failed-invocation redelivery remains eligible. Error events preserve logical completion timestamps. The clock fix uses coherent logical millisecond boundaries, includes observed descendant starts in active containing contexts, and keeps execution-view invocation ends at or beyond SDK timestamps they actually observed.
Validation:
Related: #941; aws/aws-durable-execution-sdk-python#428; aws/aws-durable-execution-sdk-python#750.