Repository navigation
fix(sdk): link resumed polling operations correctly - #964
Open
zhongkechen wants to merge 17 commits into
Open
zhongkechen wants to merge 17 commits into
zhongkechen wants to merge 17 commits into
Conversation
zhongkechen
requested a deployment
to
ai-pr-review-runtime
October 3, 2026 03:00 — with
GitHub Actions
Waiting
zhongkechen
had a problem deploying
to
ai-pr-review-runtime
October 3, 2026 03:00 — with
GitHub Actions
Error
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This was referenced Oct 3, 2026
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
zhongkechen
had a problem deploying
to
ai-pr-review-runtime
October 6, 2026 19:23 — with
GitHub Actions
Error
zhongkechen
had a problem deploying
to
ai-pr-review-runtime
October 6, 2026 22:23 — with
GitHub Actions
Failure
added 5 commits
October 6, 2026 23:27
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codex AI reviewNo actionable findings. Residual risk: tests were not executed, and the newly pinned external conformance revisions could not be inspected under the review constraints. Reviewed commit |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #963.
A resumed wait-for-condition operation omitted its link to the initial operation segment, while its first polling attempt received that link even though it was not a continuation. This broke cross-invocation navigation and the existing invocation-view case-9 contract.
Use the same continuation links as other replayed STEP/CONTEXT operations: initial operation, then Workflow. Each attempt keeps its operation parent and links only to Workflow. Preserve IDs, sampling, checkpoints, replay behavior and plugin APIs.
Validation: explicit/global-provider regressions reproduce the two incorrect link shapes before the fix. The unchanged public local wait-for-condition handler succeeds with result 2; all shared case-9 telemetry assertions pass on its seven exported spans. Full OTel tests, ESM/CJS/type builds and Biome pass; existing conformance assertions are unchanged. Pin the requirements to published shared revision
a628f5589bbf067a441696c792ab3023c0d0899b, matching the reusable workflow and its current continuation-link contract; this revision contains cases 1–20 and requires no companion handler changes. Deployed cross-SDK validation is coordinated in #960.This branch carries the separately reviewed CI deployment repair from #959; merge #959 first, then update this branch from main to remove that shared diff. The live-clock correction is tracked separately in #962.
Shared CI prerequisites include the validated callback/promise-any history test corrections from #959; independently delivered wakeups change invocation grouping, while operation counts and final outcomes remain strict.