Skip to content

fix(sdk): link resumed polling operations correctly - #964

Open
zhongkechen wants to merge 17 commits into
mainfrom
fix/otel-polling-replay-links
Open

zhongkechen wants to merge 17 commits into
mainfrom
fix/otel-polling-replay-links

Conversation

@zhongkechen

@zhongkechen zhongkechen commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #963.

A resumed wait-for-condition operation omitted its link to the initial operation segment, while its first polling attempt received that link even though it was not a continuation. This broke cross-invocation navigation and the existing invocation-view case-9 contract.

Use the same continuation links as other replayed STEP/CONTEXT operations: initial operation, then Workflow. Each attempt keeps its operation parent and links only to Workflow. Preserve IDs, sampling, checkpoints, replay behavior and plugin APIs.

Validation: explicit/global-provider regressions reproduce the two incorrect link shapes before the fix. The unchanged public local wait-for-condition handler succeeds with result 2; all shared case-9 telemetry assertions pass on its seven exported spans. Full OTel tests, ESM/CJS/type builds and Biome pass; existing conformance assertions are unchanged. Pin the requirements to published shared revision a628f5589bbf067a441696c792ab3023c0d0899b, matching the reusable workflow and its current continuation-link contract; this revision contains cases 1–20 and requires no companion handler changes. Deployed cross-SDK validation is coordinated in #960.

This branch carries the separately reviewed CI deployment repair from #959; merge #959 first, then update this branch from main to remove that shared diff. The live-clock correction is tracked separately in #962.

Shared CI prerequisites include the validated callback/promise-any history test corrections from #959; independently delivered wakeups change invocation grouping, while operation counts and final outcomes remain strict.

@zhongkechen
zhongkechen deployed to ai-pr-review-runtime October 3, 2026 03:07 — with GitHub Actions Active
Comment thread packages/aws-durable-execution-sdk-js-examples/scripts/deploy-lambda.ts Outdated
@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen deployed to ai-pr-review-runtime October 3, 2026 03:36 — with GitHub Actions Active
@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen deployed to ai-pr-review-runtime October 3, 2026 05:00 — with GitHub Actions Active
@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen deployed to ai-pr-review-runtime October 4, 2026 02:41 — with GitHub Actions Active
@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen had a problem deploying to ai-pr-review-runtime October 6, 2026 22:23 — with GitHub Actions Failure
@zhongkechen
zhongkechen deployed to ai-pr-review-runtime October 7, 2026 02:05 — with GitHub Actions Active
@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen deployed to ai-pr-review-runtime October 7, 2026 17:24 — with GitHub Actions Active
@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen deployed to ai-pr-review-runtime October 7, 2026 19:15 — with GitHub Actions Active
@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen deployed to ai-pr-review-runtime October 7, 2026 21:01 — with GitHub Actions Active
@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen deployed to ai-pr-review-runtime October 7, 2026 23:04 — with GitHub Actions Active
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

Codex AI review

No actionable findings. Residual risk: tests were not executed, and the newly pinned external conformance revisions could not be inspected under the review constraints.

Reviewed commit 101779cdf0c09af07dfd11126ab93177fa29168c. Workflow run

This branch was successfully deployed

1 active deployment
ai-pr-review-runtime — 101779cd Deployed Oct 7, 2026 by zhongkechen via ai-pr-review / Codex review / Generate Codex review #979
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

waitForCondition replay links attach to the wrong invocation-view span

1 participant