boards/arm/rp23xx: add hardware SHA-256 cryptodev support#18681
Merged
lupyuen merged 1 commit intoapache:masterfrom Apr 10, 2026
Merged
boards/arm/rp23xx: add hardware SHA-256 cryptodev support#18681lupyuen merged 1 commit intoapache:masterfrom
lupyuen merged 1 commit intoapache:masterfrom
Conversation
karaketir16
changed the title
github-actions
bot
added
Arch: arm
xiaoxiang781216
previously approved these changes
Apr 7, 2026
Contributor
|
Hi @karaketir16 please fix |
acassis
reviewed
Apr 7, 2026
Add an RP23xx hardware crypto driver for /dev/crypto with SHA-256 support backed by the RP2350 SHA accelerator. Wire the new driver into the RP23xx ARM build and register CRYPTO_SHA2_256 through cryptodev. Also fix the RP23xx SHA256 CSR BSWAP bit definition in both the ARM and RISC-V RP23xx headers. The previous value used bit 18, but the RP2350 hardware uses bit 12. Without this fix, the accelerator hashed input words with the wrong byte order and produced incorrect digests. Signed-off-by: karaketir16 <osmankaraketir@gmail.com>
karaketir16
force-pushed
the
crypto-rp23xx
branch
from
b8d7794 to
84a10b1
Compare
Contributor
Author
|
https://github.com/apache/nuttx/actions/runs/24106742084/job/70331973802#step:10:615 I don't know why it failed, seems irrelevant with this PR. |
Member
|
@karaketir16 I restarted the build. |
Member
|
BTW we're testing the new NuttX Build Monitor (pic below), which will help us discover build problems: https://lupyuen.github.io/nuttx-github-jobs/build-monitor The build seems to be failing due to problems at chromium.googlesource.com: #18562 (comment) 
|
Member
|
Here's the fix for the failing build, let's wait for it to be merged: |
xiaoxiang781216
approved these changes
Apr 8, 2026
simbit18
approved these changes
Apr 10, 2026
lupyuen
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an RP23xx hardware crypto driver for /dev/crypto with SHA-256 support backed by the RP2350 SHA accelerator.
Wire the new driver into the RP23xx ARM build and register CRYPTO_SHA2_256 through cryptodev.
Also fix the RP23xx SHA256 CSR BSWAP bit definition in both the ARM and RISC-V RP23xx headers. The previous value used bit 18, but the RP2350 hardware uses bit 12. Without this fix, the accelerator hashed input words with the wrong byte order and produced incorrect digests.
It is faster than
crypto/cryptosoft.c.