docs: clean OSS and COS configuration tables#3452
Open
Sidra-009 wants to merge 3 commits into
Open
Conversation
Collaborator
|
This is replacing #3451 right? Do you mind closing out that other PR? |
Author
ebyhr
reviewed
Jun 4, 2026
Comment on lines
+219
to
+225
| catalog = load_catalog( | ||
| **{ | ||
| "s3.endpoint": "https://cos.ap-guangzhou.myqcloud.com", | ||
| "s3.access-key-id": "admin", | ||
| "s3.secret-access-key": "password", | ||
| } | ||
| ) |
Member
There was a problem hiding this comment.
Does this example truly function without the type or uri properties?
I feel this example doesn't offer much benefit because it's almost a repeat of the table above. We could remove this example.
Author
There was a problem hiding this comment.
thanks for the feedback i removed the example block
ebyhr
reviewed
Jun 5, 2026
| | s3.secret-access-key | password | Secret key for COS | | ||
| | s3.session-token | AQoDYXdzEJr... | Optional session token | | ||
|
|
||
| <!-- markdown-link-check-disable --> |
Member
There was a problem hiding this comment.
It was <!-- markdown-link-check-enable-->. Why did you change it to -disable?
|
|
||
| ### Alibaba Cloud Object Storage Service (OSS) | ||
|
|
||
| <!-- markdown-link-check-disable --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
fixed formatting issues in OSS and Tencent COS configuration documentation
changes
testing