Skip to content

refactor(errors): open help destinations through the navigator #22768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-allison merged 1 commit into from
Oct 25, 2026
Merged

refactor(errors): open help destinations through the navigator #22768

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions AnkiDroid/src/main/java/com/ichi2/anki/CoroutineHelpers.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,15 @@ import com.ichi2.anki.common.annotations.UseContextParameter
import com.ichi2.anki.common.coroutines.applicationScope
import com.ichi2.anki.common.crashreporting.CrashReportService
import com.ichi2.anki.common.destinations.DeckOptionsDestination
import com.ichi2.anki.common.destinations.DeferredNavigation
import com.ichi2.anki.common.destinations.PreferencesDestination
import com.ichi2.anki.common.destinations.toIntent
import com.ichi2.anki.common.utils.android.isRobolectric
import com.ichi2.anki.dialogs.DatabaseErrorDialog
import com.ichi2.anki.dialogs.DatabaseErrorDialog.DatabaseErrorDialogType
import com.ichi2.anki.exception.CollectionLockedException
import com.ichi2.anki.exception.StorageAccessException
import com.ichi2.anki.exception.StorageNotConfiguredException
import com.ichi2.anki.pages.toIntent
import com.ichi2.anki.preferences.toIntent
import com.ichi2.anki.progress.blockTouches
import com.ichi2.anki.progress.unblockTouches
import com.ichi2.anki.snackbar.showSnackbar
Expand Down Expand Up @@ -758,7 +758,7 @@ data class CrashReportData(
// if we're in the error dialog, we have no context of the deck which caused the exception
// assume it's the current deck
val openCurrentDeckOptions = DeckOptionsDestination.fromCurrentDeck()
context.startActivity(openCurrentDeckOptions.toIntent(context))
context.startActivity(with(DeferredNavigation) { openCurrentDeckOptions.toIntent() })
// dismiss the dialog - the user should have resolved the issue
return true
}
Expand All @@ -773,7 +773,7 @@ data class CrashReportData(

override suspend fun execute(context: Context): Boolean {
Timber.i("Opening 'Advanced settings'")
context.startActivity(PreferencesDestination.Advanced.toIntent(context))
context.startActivity(with(DeferredNavigation) { PreferencesDestination.Advanced.toIntent() })
return true
}
}
Expand Down
Loading