Skip to content

refactor(errors): open help destinations through the navigator - #22768

Merged
david-allison merged 1 commit into
ankidroid:mainfrom
criticalAY:refactor/coroutine-helpers-groundwork
Oct 25, 2026
Merged

david-allison merged 1 commit into
ankidroid:mainfrom
criticalAY:refactor/coroutine-helpers-groundwork

Conversation

@criticalAY

Copy link
Copy Markdown
Contributor

Note

Assisted-by: Claude Opus 5.5

Purpose / Description

The error dialog's "deck options" and "advanced settings" help actions built their intents with the app's own toIntent(context) functions. They now go through the navigator, which removes two of the things keeping CoroutineHelpers in the app.

Fixes

Approach

Both actions use with(DeferredNavigation) { destination.toIntent() }. The intents are the same: the app's getIntent helpers only use the context to name the target activity.

How Has This Been Tested?

Local compile and CI

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

The error dialog's deck options and advanced settings help actions
no longer need the app's toIntent functions.

Assisted-by: Claude Opus 5.5

@david-allison david-allison left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers!

@david-allison
david-allison added this pull request to the merge queue Oct 25, 2026
Merged via the queue into ankidroid:main with commit 0efacb2 Oct 25, 2026
21 checks passed
@github-actions github-actions Bot added this to the 2.26 release milestone Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants