Repository navigation
refactor(errors): open help destinations through the navigator - #22768
Merged
david-allison merged 1 commit intoOct 25, 2026
Merged
david-allison merged 1 commit into
david-allison merged 1 commit into
Conversation
The error dialog's deck options and advanced settings help actions no longer need the app's toIntent functions. Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Assisted-by: Claude Opus 5.5
Purpose / Description
The error dialog's "deck options" and "advanced settings" help actions built their intents with the app's own
toIntent(context)functions. They now go through the navigator, which removes two of the things keepingCoroutineHelpersin the app.Fixes
Approach
Both actions use
with(DeferredNavigation) { destination.toIntent() }. The intents are the same: the app'sgetIntenthelpers only use the context to name the target activity.How Has This Been Tested?
Local compile and CI
Checklist