Skip to content

fix(release): accept manager version bumps and render the new release's changelog #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alongubkin merged 2 commits into from
Oct 5, 2026
Merged

fix(release): accept manager version bumps and render the new release's changelog #876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46feeff
fix(release): accept manager version bumps and render the new release…
alongubkin Oct 5, 2026
bbada39
fix(release): require the release version in the manager chart and mo…
alongubkin Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions .github/workflows/release-qualification.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,14 @@ jobs:
echo "::error::Release qualification requires a Linear-derived branch"
exit 1
fi
allowed='^(Cargo.toml|Cargo.lock|packages/(core|permissions|commands|sdk|testing|bindings|ai-gateway)/package.json|packages/permissions/generated/(bytes\.js|compiler\.js|compiler\.d\.ts)|crates/alien-bindings-node/package.json|client-sdks/(platform|manager)/typescript/(package.json|jsr.json|package-lock.json|src/lib/config.ts|\.speakeasy/(gen.yaml|gen.lock))|packages/bindings/npm/(darwin-arm64|darwin-x64|linux-x64-gnu|linux-arm64-gnu)/package.json)$'
allowed='^(Cargo.toml|Cargo.lock|packages/(core|permissions|commands|sdk|testing|bindings|ai-gateway)/package.json|packages/permissions/generated/(bytes\.js|compiler\.js|compiler\.d\.ts)|crates/alien-bindings-node/package.json|client-sdks/(platform|manager)/typescript/(package.json|jsr.json|package-lock.json|src/lib/config.ts|\.speakeasy/(gen.yaml|gen.lock))|packages/bindings/npm/(darwin-arm64|darwin-x64|linux-x64-gnu|linux-arm64-gnu)/package.json|infra/helm/alien-manager/Chart.yaml|infra/aws-ecs-manager/variables.tf)$'
unexpected=$(git diff --name-only "$BASE_SHA" "$SOURCE_REF" | grep -Ev "$allowed" || true)
if [ -n "$unexpected" ]; then
echo "::error::Release PR contains non-version files:"
echo "$unexpected"
exit 1
fi
BASE_SHA="$BASE_SHA" SOURCE_REF="$SOURCE_REF" node --input-type=module <<'NODE'
BASE_SHA="$BASE_SHA" SOURCE_REF="$SOURCE_REF" RELEASE_VERSION="$CURRENT_VERSION" node --input-type=module <<'NODE'
import { execFileSync } from 'node:child_process';
import { withSDKReleaseVersion } from './scripts/sdk-release-metadata.mjs';

Expand Down Expand Up @@ -97,6 +97,14 @@ jobs:
? content.replace(/(typescript:\n version: )[^\n]+/, '$1__RELEASE_VERSION__')
: content.replace(/( releaseVersion: )[^\n]+/, '$1__RELEASE_VERSION__');

const releaseVersion = process.env.RELEASE_VERSION.replaceAll('.', '\\.');
const requireVersion = (path, content, pattern) => {
if (!pattern.test(content)) {
console.error('::error::' + path + ' does not carry release version ' + process.env.RELEASE_VERSION);
process.exit(1);
}
};

for (const path of changed) {
let base;
let head;
Expand All @@ -111,6 +119,22 @@ jobs:
} else if (path.endsWith('/src/lib/config.ts')) {
base = withSDKReleaseVersion(fromRef(process.env.BASE_SHA, path), '0.0.0');
head = withSDKReleaseVersion(fromRef(process.env.SOURCE_REF, path), '0.0.0');
} else if (path === 'infra/helm/alien-manager/Chart.yaml') {
const normalizeChart = (content) => content
.replace(/^version: .*$/m, 'version: __RELEASE_VERSION__')
.replace(/^appVersion: .*$/m, 'appVersion: __RELEASE_VERSION__');
Comment thread
alongubkin marked this conversation as resolved.
const chart = fromRef(process.env.SOURCE_REF, path);
requireVersion(path, chart, new RegExp('^version: ' + releaseVersion + '$', 'm'));
requireVersion(path, chart, new RegExp('^appVersion: "' + releaseVersion + '"$', 'm'));
base = normalizeChart(fromRef(process.env.BASE_SHA, path));
head = normalizeChart(chart);
} else if (path === 'infra/aws-ecs-manager/variables.tf') {
const imagePattern = /(ghcr\.io\/alienplatform\/alien-manager:v)[0-9][^"]*/;
const normalizeModule = (content) => content.replace(imagePattern, '$1__RELEASE_VERSION__');
const module = fromRef(process.env.SOURCE_REF, path);
requireVersion(path, module, new RegExp('ghcr\\.io/alienplatform/alien-manager:v' + releaseVersion + '"'));
base = normalizeModule(fromRef(process.env.BASE_SHA, path));
head = normalizeModule(module);
} else {
continue;
}
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,9 @@ jobs:
uses: orhun/git-cliff-action@v4
with:
config: cliff.toml
args: --latest --strip header
# The release tag does not exist yet: render the commits since the
# previous tag under the new version.
args: --unreleased --tag v${{ needs.prepare.outputs.version }} --strip header
env:
OUTPUT: CHANGELOG-release.md

Expand Down
Loading