Skip to content

fix(release): accept manager version bumps and render the new release's changelog - #876

Merged
alongubkin merged 2 commits into
mainfrom
alon/alien-1219-release-flow-fixes
Oct 5, 2026
Merged

alongubkin merged 2 commits into
mainfrom
alon/alien-1219-release-flow-fixes

Conversation

@alongubkin

Copy link
Copy Markdown
Member

What

Two release-flow bugs that would hit the next stable release:

  1. The next version PR fails "Release qualification". Prepare now bumps infra/helm/alien-manager/Chart.yaml and infra/aws-ecs-manager/variables.tf, but the detect step's file allowlist in release-qualification.yml doesn't list them, so it fails with "Release PR contains non-version files".
  2. Each GitHub release body lists the previous release's changes. generate-changelog runs git-cliff --latest before the new tag exists, so it renders the range ending at the previous tag. The v3.3.26 body lists fix: scope Azure storage lifecycle rules to their container #707–chore: release v3.3.25 #756, which shipped in v3.3.25.

How

  1. Add both files to the allowlist, and normalize their version fields (version/appVersion in the chart, the alien-manager:v… image default in the module) so any other change to them still fails the check.
  2. Use --unreleased --tag v<version>: the commits since the last tag, rendered under the new version.

Verification

🤖 Generated with Claude Code

…'s changelog

Prepare now bumps the manager Helm chart and ECS module, but the release
qualification allowlist rejected both files. Allow them and check that
only their version fields changed.

The changelog ran git-cliff --latest before the new tag existed, so each
release body listed the previous release's changes. Render the commits
since the last tag under the new version instead.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[High risk] Changes release workflow version detection and changelog generation.

The PR appears safe to merge based on the reviewed release-qualification and changelog changes.

Summary

The PR allows prepared manager chart and ECS module version bumps through release qualification while rejecting other metadata changes. It also generates the release changelog from unreleased commits under the new version rather than rendering the previous tag’s range.

  • The follow-up change checks all three manager version values against the PR-head workspace version.
  • The existing prepare step produces the formats those checks expect.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Prepare version bump] --> B[Release PR]
  B --> C[Check allowed files and manager versions]
  C --> D[Qualify release]
  D --> E[Generate unreleased changelog under new tag]
Loading

Reviews (2) · Last reviewed commit: "fix(release): require the release versio..."

Comment thread .github/workflows/release-qualification.yml
…dule

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@alongubkin

Copy link
Copy Markdown
Member Author

@greptileai review

@alongubkin
alongubkin merged commit 5b5250f into main Oct 5, 2026
22 checks passed
@alongubkin
alongubkin deleted the alon/alien-1219-release-flow-fixes branch October 5, 2026 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant