Repository navigation
fix(release): accept manager version bumps and render the new release's changelog - #876
Merged
Merged
Conversation
…'s changelog Prepare now bumps the manager Helm chart and ECS module, but the release qualification allowlist rejected both files. Allow them and check that only their version fields changed. The changelog ran git-cliff --latest before the new tag existed, so each release body listed the previous release's changes. Render the commits since the last tag under the new version instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
…dule Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
@greptileai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two release-flow bugs that would hit the next stable release:
infra/helm/alien-manager/Chart.yamlandinfra/aws-ecs-manager/variables.tf, but the detect step's file allowlist inrelease-qualification.ymldoesn't list them, so it fails with "Release PR contains non-version files".generate-changelogrunsgit-cliff --latestbefore the new tag exists, so it renders the range ending at the previous tag. The v3.3.26 body lists fix: scope Azure storage lifecycle rules to their container #707–chore: release v3.3.25 #756, which shipped in v3.3.25.How
version/appVersionin the chart, thealien-manager:v…image default in the module) so any other change to them still fails the check.--unreleased --tag v<version>: the commits since the last tag, rendered under the new version.Verification
sedbumps for 3.3.27 tomain: the old allowlist rejects exactly the two files; the new allowlist and the metadata check pass. A second scratch commit that also changestype:in the chart and the image registry in the module fails with "Release PR changes non-version metadata".git-cliff 2.14.2withcliff.tomlonmain:--latestrenders feat(cli): enable remote-sandbox without flags uses the platform's default image #753–fix: pin the official CLI to a platform build that matches current alien #779 (the v3.3.26 range);--unreleased --tag v3.3.27renders chore(deps): update rust crate tower-http to v0.7.1 #553–fix: acknowledge completed pull execution receipts #873, the 68 commits since v3.3.26.🤖 Generated with Claude Code