feat: form control scaffold applier for pp-form-control - #90
Open
zekelinAlex wants to merge 1 commit into
Open
zekelinAlex wants to merge 1 commit into
zekelinAlex wants to merge 1 commit into
Conversation
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the FormControl applier for pp-form-control. Appends the rendered control into the single cell of the target row, requires exactly one cell like the old script did, and marks the cell with rowspan/colspan/auto for SubGrid controls. Picks dialogcontrol.xml for dialog forms.
Stacked on the cell PR, merge after it. Parity run covered all 11 control types plus the readonly/required/unbound toggles: byte-identical output, the form-id-only call now works, and the dialog chain runs end to end. Bonus finding from the baseline: when a dialog scaffold failed halfway, the old pipeline left duplicate orphaned type-60 RootComponents in Solution.xml - the applier path doesn't.