Update to quickpay-php-sdk 1.0.0-beta.2 - #51
Merged
Merged
Conversation
…dency beta.2 slims the SDK's dependencies and removes CollectionRequestOptions::new(). Neither reaches this package: we never construct CollectionRequestOptions — the gateway only uses the payments endpoint's single-resource methods — so no code changed. Verified with the suite and a live smoke run against the real API. The constraint stays ^1.0@beta rather than pinning to beta.2. Nothing here depends on anything beta.2 added, and leaving it wide means --prefer-lowest keeps resolving beta.1, so CI now exercises both betas rather than only the newest. Dropping the SDK's webmozart/assert requirement did make one of our own dev dependencies pointless: phpstan/phpstan-webmozart-assert teaches PHPStan about Assert:: calls, and there are none left anywhere in the analysed path. PHPStan reports the same clean result without it. webmozart/assert itself is still in the dev tree via infection and reflection-docblock; it is simply no longer a runtime dependency that consumers inherit.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.x #51 +/- ##
=========================================
Coverage 97.40% 97.40%
Complexity 126 126
=========================================
Files 14 14
Lines 347 347
=========================================
Hits 338 338
Misses 9 9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
setono/quickpay-php-sdkto1.0.0-beta.2.Neither beta.2 change reaches this package
CollectionRequestOptions::new()removed (BC break). We never constructCollectionRequestOptionsat all — the gateway only uses the payments endpoint's single-resource methods (
getById,create,createLink,capture,refund,cancel). No pagination, no collections.webmozart/assertdropped as a dependency. We never calledAssert::either.So no gateway code changed. Verified with the full suite and a live smoke run against the real API on
beta.2.
The constraint stays
^1.0@betaDeliberately not pinned to
beta.2: nothing here depends on anything beta.2 introduced, and leaving theconstraint wide means
--prefer-loweststill resolvesbeta.1. CI therefore now exercises bothbetas rather than only the newest — which is worth more than pinning, given we are compatible with both.
One dev dependency became dead
phpstan/phpstan-webmozart-assertexists to teach PHPStan aboutAssert::calls. With the SDK no longerusing webmozart/assert, there are none anywhere in the analysed path — PHPStan analyses
srconly, andsrcnever calledAssert::in the first place. PHPStan reports the same clean result without theextension, so it is removed.
webmozart/assertitself is still present in the dev tree viainfectionandphpdocumentor/reflection-docblock. What changed is that it is no longer a runtime dependencyconsumers inherit — which is the point of the SDK's slim-down.
Verified
224 tests, PHPStan level 8, ECS,
composer normalize, dependency-analyser, mutation testing at81% MSI / 82% covered. Plus a live
e2e:smokeon beta.2, which created a real payment and returned aworking payment-window url.