Skip to content

Update to quickpay-php-sdk 1.0.0-beta.2 - #51

Merged
loevgaard merged 1 commit into
2.xfrom
chore/sdk-beta-2
Aug 10, 2026
Merged

Update to quickpay-php-sdk 1.0.0-beta.2#51
loevgaard merged 1 commit into
2.xfrom
chore/sdk-beta-2

Conversation

@loevgaard

Copy link
Copy Markdown
Member

Updates setono/quickpay-php-sdk to 1.0.0-beta.2.

Neither beta.2 change reaches this package

  • CollectionRequestOptions::new() removed (BC break). We never construct CollectionRequestOptions
    at all — the gateway only uses the payments endpoint's single-resource methods (getById, create,
    createLink, capture, refund, cancel). No pagination, no collections.
  • webmozart/assert dropped as a dependency. We never called Assert:: either.

So no gateway code changed. Verified with the full suite and a live smoke run against the real API on
beta.2.

The constraint stays ^1.0@beta

Deliberately not pinned to beta.2: nothing here depends on anything beta.2 introduced, and leaving the
constraint wide means --prefer-lowest still resolves beta.1. CI therefore now exercises both
betas rather than only the newest — which is worth more than pinning, given we are compatible with both.

One dev dependency became dead

phpstan/phpstan-webmozart-assert exists to teach PHPStan about Assert:: calls. With the SDK no longer
using webmozart/assert, there are none anywhere in the analysed path — PHPStan analyses src only, and
src never called Assert:: in the first place. PHPStan reports the same clean result without the
extension, so it is removed.

webmozart/assert itself is still present in the dev tree via infection and
phpdocumentor/reflection-docblock. What changed is that it is no longer a runtime dependency
consumers inherit — which is the point of the SDK's slim-down.

Verified

224 tests, PHPStan level 8, ECS, composer normalize, dependency-analyser, mutation testing at
81% MSI / 82% covered. Plus a live e2e:smoke on beta.2, which created a real payment and returned a
working payment-window url.

…dency

beta.2 slims the SDK's dependencies and removes CollectionRequestOptions::new().
Neither reaches this package: we never construct CollectionRequestOptions — the
gateway only uses the payments endpoint's single-resource methods — so no code
changed. Verified with the suite and a live smoke run against the real API.

The constraint stays ^1.0@beta rather than pinning to beta.2. Nothing here depends
on anything beta.2 added, and leaving it wide means --prefer-lowest keeps
resolving beta.1, so CI now exercises both betas rather than only the newest.

Dropping the SDK's webmozart/assert requirement did make one of our own dev
dependencies pointless: phpstan/phpstan-webmozart-assert teaches PHPStan about
Assert:: calls, and there are none left anywhere in the analysed path. PHPStan
reports the same clean result without it. webmozart/assert itself is still in the
dev tree via infection and reflection-docblock; it is simply no longer a runtime
dependency that consumers inherit.
@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.40%. Comparing base (448abf9) to head (5170e66).

Additional details and impacted files
@@            Coverage Diff            @@
##                2.x      #51   +/-   ##
=========================================
  Coverage     97.40%   97.40%           
  Complexity      126      126           
=========================================
  Files            14       14           
  Lines           347      347           
=========================================
  Hits            338      338           
  Misses            9        9           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@loevgaard
loevgaard merged commit 55f465e into 2.x Aug 10, 2026
21 checks passed
@loevgaard
loevgaard deleted the chore/sdk-beta-2 branch August 10, 2026 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant