Require the stable setono/quickpay-php-sdk 1.0.0 - #56
Merged
Conversation
The SDK went stable today, so the constraint drops from ^1.0@beta to a plain ^1.0. The change that matters to consumers is not the version — it is that "minimum-stability": "beta" is no longer needed at all. That requirement has been in the installation instructions since the SDK adoption, and it was the one piece of friction a project could not avoid. Verified with a clean install in an empty project: `composer require setono/quickpay-php-sdk: ^1.0` resolves v1.0.0 with default settings and no stability flags. The note is removed from the README, the upgrade guide now says the flag can be dropped again, and CLAUDE.md keeps only the part of the pre-release history that explains anything. 1.0.0 itself is beta.2 plus packaging fixes — a lean dist (export-ignored CLAUDE.md and examples/), a docblock correction and CI tidying. No API change, so no gateway code changed. Verified with the suite and a live smoke run against the real API. ^1.0 also excludes pre-releases outright, so --prefer-lowest now resolves 1.0.0 rather than a beta.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.x #56 +/- ##
=========================================
Coverage 97.43% 97.43%
Complexity 126 126
=========================================
Files 14 14
Lines 351 351
=========================================
Hits 342 342
Misses 9 9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setono/quickpay-php-sdkwent stable, so the constraint drops from^1.0@betato a plain^1.0.What this actually unblocks
The version bump is the small part.
"minimum-stability": "beta"is no longer needed at all — thatrequirement has been in the installation instructions since the SDK adoption and was the one piece of
friction a consuming project could not avoid.
Verified rather than assumed, with a clean install in an empty project:
docs/UPGRADE-2.0.mdnow says the flag can be dropped again if it was only ever added for the SDK.CLAUDE.mdkeeps only the part of the pre-release history that still explains something — namely whythe constraint used to be so specific (the gateway cannot run on alpha.1 and breaks on alpha.1–2), and
notes that
^1.0excludes pre-releases outright so that concern is retired.No code change
1.0.0isbeta.2plus packaging: a lean dist (CLAUDE.md,examples/and.env.local.examplearenow
export-ignored, socomposer requireships onlyLICENSE,composer.jsonandsrc/), a docblockcorrection, and CI tidying. No API change.
Confirmed with the full suite and a live
e2e:smokeagainst the real API on 1.0.0.Note on
--prefer-lowest^1.0excludes pre-releases, so the lowest-resolution CI jobs now install1.0.0rather than a beta.That ends the both-betas coverage from #51, which is the correct trade — there is no longer any reason
for a consumer to be on a pre-release.
Verified
226 tests, PHPStan level 8, ECS,
composer normalize, dependency-analyser, mutation testing at82% MSI / 83% covered, plus the live smoke run.