fix(qwik): surface container resume failures instead of hanging#8772
Open
maiieul wants to merge 1 commit into
Open
fix(qwik): surface container resume failures instead of hanging#8772maiieul wants to merge 1 commit into
maiieul wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 03fae8a The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@qwik.dev/core
@qwik.dev/router
eslint-plugin-qwik
create-qwik
@qwik.dev/optimizer
commit: |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
The container state-resume pipeline swallowed a thrown resume: scheduleProcessContainerStateData's onError marked the container done but never called markContainerDataReady, so every whenContainerDataReady waiter hung forever — and it logged nothing, so the failure was invisible. Now report the error via logError and unblock waiters so the rest of the page can still resume. Regression test drives the pipeline with a throwing iterator and asserts it resolves rather than timing out (it times out without the fix).
maiieul
force-pushed
the
claude/surface-resume-failures
branch
2 times, most recently
from
5329361 to
03fae8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description
The container state-resume pipeline (
process-state-data.ts) swallowed a thrown resume:scheduleProcessContainerStateData'sonErrormarked the container done but never calledmarkContainerDataReady, so everywhenContainerDataReadywaiter hung forever — and it logged nothing, so the failure was invisible (a silent hang rather than a surfaced error).Now it reports the error via
logErrorand unblocks waiters so the rest of the page can still resume (graceful degradation). Includes a regression test that drives the pipeline with a throwing iterator and asserts it resolves instead of timing out (it times out without the fix).Split out of the ErrorBoundary PR (#8745), where this was discovered — it's an independent core-resume robustness fix.