fix(qwik): unblock vnode-data resume waiters on failure instead of hanging#8773
Merged
Merged
Conversation
…nging On a vnode-data resume error, logError and markVNodeDataReady so onVNodeDataReady/whenVNodeDataReady waiters fire instead of hanging on the bare throw.
🦋 Changeset detectedLatest commit: fd9f197 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@qwik.dev/core
@qwik.dev/router
eslint-plugin-qwik
create-qwik
@qwik.dev/optimizer
commit: |
Varixo
approved these changes
Jun 26, 2026
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
github-project-automation
Bot
moved this from Waiting For Review
to Done
in Qwik Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description
Sibling to #8772 (which fixed the container state-data side). The vnode-data resume pipeline had the same class of bug: a thrown resume left
onVNodeDataReady/whenVNodeDataReady/onContainerDataReadywaiters hanging on a barethrow. Now it logs the error and callsmarkVNodeDataReadyso the waiters fire instead of hanging silently.