Skip to content

Add death sound and more sounds #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
orpos wants to merge 2 commits into
base: master
Choose a base branch
from
+16 −12
Open

Add death sound and more sounds #56

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
987eb68
add death sound and change from whitelist to blacklist for sound filt…
orpos Sep 6, 2026
ee721db
Update src/main/kotlin/de/snowii/extractor/extractors/Entities.kt
orpos Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions src/main/kotlin/de/snowii/extractor/extractors/Entities.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,18 @@ class Entities : Extractor.Extractor {
if (entity is LivingEntity) {
entityJson.addProperty("experience_reward", entity.getBaseExperienceReward(server.overworld()))

if (entityName in TARGET_HURT_SOUND_ENTITIES) {
if (entityName !in TARGET_SOUND_BLACKLIST) {
Comment thread
coderabbitai[bot] marked this conversation as resolved.
val hurtSound = getHurtSound(entity, damageSource)
val hurtSoundId = hurtSound?.let(BuiltInRegistries.SOUND_EVENT::getKey)?.path
if (hurtSoundId != null) {
entityJson.addProperty("hurt_sound", hurtSoundId)
}

val deathSound = getDeathSound(entity)
val deathSoundId = deathSound?.let(BuiltInRegistries.SOUND_EVENT::getKey)?.path
if (deathSoundId != null) {
entityJson.addProperty("death_sound", deathSoundId)
}
}
}
entityJson.addProperty("attackable", entity.isAttackable)
Expand Down Expand Up @@ -121,22 +127,20 @@ class Entities : Extractor.Extractor {
private fun getHurtSound(entity: LivingEntity, damageSource: DamageSource) =
getHurtSoundMethod.invoke(entity, damageSource) as? net.minecraft.sounds.SoundEvent

private fun getDeathSound(entity: LivingEntity) =
getDeathSoundMethod.invoke(entity) as? net.minecraft.sounds.SoundEvent

companion object {
private val TARGET_HURT_SOUND_ENTITIES = setOf(
"bogged",
"drowned",
"enderman",
"husk",
"parched",
"skeleton",
"stray",
"wither_skeleton",
"zombie",
"zombie_villager",
private val TARGET_SOUND_BLACKLIST = setOf(
"slime",
"copper_golem"
)

private val getHurtSoundMethod = LivingEntity::class.java
.getDeclaredMethod("getHurtSound", DamageSource::class.java)
.apply { isAccessible = true }
private val getDeathSoundMethod = LivingEntity::class.java
.getDeclaredMethod("getDeathSound")
.apply { isAccessible = true }
}
}