Repository navigation
osprey: Corrected docs that said Rust keeps the strict-maximum C selection - #4722
Merged
brendanx67 merged 1 commit intoSep 28, 2026
Conversation
…tion * maccoss/osprey#69 adopted the 1% rule with no opt-out, so the two implementations agree * Resolved the C#-only divergence entry and reworded the docs, error text and comments See TODO-20260924_osprey_svm_c_selection.md in pwiz-ai/todos Co-Authored-By: Claude <noreply@anthropic.com>
brendanx67
deleted the
Skyline/work/20260927_osprey_c_selection_rust_docs
branch
September 28, 2026 04:39
chambm
pushed a commit
that referenced
this pull request
Oct 5, 2026
…ction (#4722) * maccoss/osprey#69 adopted the 1% C-selection rule with no opt-out, so C# and Rust agree * Resolved the C#-only divergence entry and reworded the docs, error text and comments See TODO-20260924_osprey_svm_c_selection.md in pwiz-ai/todos Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
07-fdr-control.md: the "[C#-ONLY DEFAULT]" divergence entry is now "[RESOLVED]", and the "C selection" section says Rust uses the same rule.20-command-line.md,DIVERGENCES.md,Osprey-workflow.html: no longer tell anyone to setOSPREY_SVM_C_TOLERANCE=0for cross-implementation comparisons. The pwiz-ai cross-impl scripts stopped pinning it in 8a547c71.Program.csstartup error for a malformed tolerance, and comments inOspreyEnvironment,PercolatorEngine,PercolatorTrainer,FdrTestandregression.ps1: describe 0 as the pre-osprey: Fixed first-pass SVM C selection being decided by noise #4703 rule, not as Rust's.See TODO-20260924_osprey_svm_c_selection.md in pwiz-ai/todos
Test plan
Build-Osprey.ps1 -Configuration Debug -RunTests -RunInspection- 604 tests, 0 inspection warningsCo-Authored-By: Claude noreply@anthropic.com