Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the repo’s SIPSorcery dependency to a security-fixed version and adjusts the WebRTC-Direct DTLS certificate creation code to match the updated DTLS certificate API, along with aligning related Microsoft.Extensions abstraction package pins and updating the transport-interop lockfile.
Changes:
- Bump
SIPSorceryto10.0.14and alignMicrosoft.Extensions.*.Abstractionspins to10.0.10. - Update WebRTC-Direct local DTLS certificate creation to the new TLS certificate API surface.
- Update
transport-interoplock file and add a small constructor smoke test for the WebRTC-Direct certificate construction path.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/samples/transport-interop/TransportInterop.csproj | Bumps Logging.Abstractions to align with updated abstraction pins. |
| src/samples/transport-interop/packages.lock.json | Updates resolved dependency graph (SIPSorcery 10.0.14, abstractions 10.0.10, and related transitive changes). |
| src/samples/pubsub-chat/PubsubChat.csproj | Aligns DI.Abstractions version to 10.0.10. |
| src/samples/perf-benchmarks/PerfBenchmarks.csproj | Aligns Logging.Abstractions version to 10.0.10. |
| src/libp2p/Libp2p.Protocols.WebRtc/WebRtcDirectProtocol.cs | Adapts local DTLS certificate creation to updated DTLS/TLS certificate API. |
| src/libp2p/Libp2p.Protocols.WebRtc.Tests/WebRtcDirectProtocolTests.cs | Adds a constructor smoke test covering DTLS certificate creation path. |
| src/libp2p/Directory.Packages.props | Central package version updates for SIPSorcery and abstraction packages. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Aug 24, 2026
This was referenced Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary