Skip to content

Expose TLS remote public keys - #205

Open
flcl42 wants to merge 5 commits into
sipsorcery-security-updatefrom
tls-remote-public-key
Open

Expose TLS remote public keys#205
flcl42 wants to merge 5 commits into
sipsorcery-security-updatefrom
tls-remote-public-key

Conversation

@flcl42

@flcl42 flcl42 commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • record the authenticated certificate key in connection state for both TLS roles
  • retain peer-address enrichment when a connection starts without a /p2p component
  • reject a certificate key that conflicts with an already authenticated identity
  • cover the public-key state and peer-address enrichment produced by a TLS handshake

Pipeline repair

This branch also includes the shared SIPSorcery security dependency update required for CI restore. It aligns the WebRTC certificate integration and is tracked independently in #208.

Validation

  • Extended the TLS handshake coverage.

@flcl42
flcl42 requested a review from rubo as a code owner August 24, 2026 06:12
@flcl42
flcl42 requested a lite review from Copilot August 24, 2026 07:03

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request exposes authenticated TLS peer public keys, preserves peer-address enrichment, and updates WebRTC certificate compatibility and dependencies.

Changes:

  • Store remote TLS certificate keys and enrich peer addresses.
  • Update WebRTC certificate creation and coverage.
  • Refresh package versions and lock files.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Summary
src/samples/transport-interop/TransportInterop.csproj Updates logging abstractions.
src/samples/transport-interop/packages.lock.json Refreshes locked dependencies.
src/samples/pubsub-chat/PubsubChat.csproj Updates dependency versions and formatting.
src/samples/perf-benchmarks/PerfBenchmarks.csproj Updates logging abstractions.
src/libp2p/Libp2p.Protocols.WebRtc/WebRtcDirectProtocol.cs Adapts certificate generation to updated APIs.
src/libp2p/Libp2p.Protocols.WebRtc.Tests/WebRtcDirectProtocolTests.cs Adds certificate-construction coverage.
src/libp2p/Libp2p.Protocols.Tls/TlsProtocol.cs Records remote keys and enriches addresses; critical key-binding and moderate no-/p2p coverage findings remain unresolved.
src/libp2p/Libp2p.Protocols.Tls.Tests/TlsProtocolTests.cs Verifies TLS keys after handshakes.
src/libp2p/Directory.Packages.props Updates central package versions.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/libp2p/Libp2p.Protocols.Tls/TlsProtocol.cs
Comment thread src/libp2p/Libp2p.Protocols.Tls/TlsProtocol.cs Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Comment thread src/libp2p/Libp2p.Protocols.Tls/TlsProtocol.cs
Comment thread src/libp2p/Libp2p.Protocols.WebRtc/WebRtcDirectProtocol.cs

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

@flcl42
flcl42 force-pushed the tls-remote-public-key branch from 8ac2321 to 6dd1f49 Compare August 24, 2026 09:20
@flcl42
flcl42 changed the base branch from main to sipsorcery-security-update August 24, 2026 09:20
@flcl42
flcl42 requested a lite review from Copilot August 24, 2026 09:29

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread src/libp2p/Libp2p.Protocols.Tls/TlsProtocol.cs

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comment thread src/libp2p/Libp2p.Protocols.IpTcp/IpTcpProtocol.cs

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants