Skip to content

Fix docs-build changed-files dependency - #2636

Open
vuule wants to merge 6 commits into
NVIDIA:mainfrom
vuule:fix-docs-build-changed-files-dependency
Open

vuule wants to merge 6 commits into
NVIDIA:mainfrom
vuule:fix-docs-build-changed-files-dependency

Conversation

@vuule

@vuule vuule commented Sep 16, 2026

Copy link
Copy Markdown

Declares changed-files as a docs-build dependency so the build_docs output is available when GitHub evaluates the job condition. Without this dependency, documentation builds are skipped even when build_docs is true.

Signed-off-by: Vukasin Milovanovic <vmilovanovic@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Sep 16, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@bdice
bdice marked this pull request as ready for review September 16, 2026 21:51
@bdice
bdice requested a review from a team as a code owner September 16, 2026 21:51
@bdice
bdice requested a review from gforsyth September 16, 2026 21:51
@bdice bdice added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Sep 16, 2026
@bdice

bdice commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

/merge

@bdice

bdice commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

/ok to test

@copy-pr-bot

copy-pr-bot Bot commented Sep 16, 2026

Copy link
Copy Markdown

/ok to test

@bdice, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@bdice

bdice commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

/ok to test b115b88

@bdice

bdice commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

/merge

@vuule

vuule commented Sep 17, 2026

Copy link
Copy Markdown
Author

@bdice I think that another test trigger comment is needed here

@bdice

bdice commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

/ok to test 5ff60e6

@bdice

bdice commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

/ok to test 50c2bd6

@bdice

bdice commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

/ok to test d0cfe89

@bdice

bdice commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

/merge

@coderabbitai

coderabbitai Bot commented Oct 7, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: NVIDIA/cuvs/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 7e10dc3d-354f-4170-82c1-b9d7ce49589e
📥 Commits

Reviewing files that changed from the base of the PR and between 3cbbaab and 467683f.

📒 Files selected for processing (1)
  • .github/workflows/pr.yaml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 10 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Chores
    • Documentation build checks now run when documentation changes are detected and wait for change detection to complete. This keeps documentation-related validation aligned with the files changed in a pull request.

Walkthrough

The docs-build job now depends on changed-files as well as docs-build-matrix. Its build_docs condition uses the changed-file result.

Changes

Documentation build workflow

Layer / File(s) Summary
Gate documentation build on changed files
.github/workflows/pr.yaml
The docs-build job adds changed-files as a dependency. Its build_docs condition uses the changed-file result.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 46768

Documentation changes remain eligible for the build on the workflow’s declared trigger. No actionable merge risk from this change remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the change: adding the changed-files dependency to docs-build.
Description check ✅ Passed The description explains why docs-build needs the dependency and how its absence can skip documentation builds.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@vuule

vuule commented Oct 7, 2026

Copy link
Copy Markdown
Author

/merge

@bdice Needs another CI trigger comment :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants