Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions memories/antigravity.md
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,13 @@ The [`google-antigravity/antigravity-sdk-python`](https://github.com/google-anti
Review bodies commonly format their verdict section as `## Verdict` (H2) or `### Verdict` (H3).
`VERDICT_MARKER_RE` must match `#{2,4}\s*Verdict\b` rather than strictly requiring `### Verdict`;
otherwise, reviews with `## Verdict` are ignored by the gate and fall back to older comments, resulting in false `stale` merge denials.
- **Unchained `ALLOW_UNREVIEWED_PUSH=1` prefix in Windows PowerShell**:
`hooks/no-push-without-self-review.py` verifies the `ALLOW_UNREVIEWED_PUSH=1` override token appears as an unchained environment prefix before the `git push` invocation (e.g. `ALLOW_UNREVIEWED_PUSH=1 git push ...`).
Windows PowerShell 5.1 does not natively support POSIX-style inline environment variable assignments and errors if typed directly.
Chaining `$env:ALLOW_UNREVIEWED_PUSH="1"; git push ...` is rejected by the hook as chained commands.
Creating a PowerShell function:
`New-Item -Path function: -Name "ALLOW_UNREVIEWED_PUSH=1" -Value { param($cmd, [Parameter(ValueFromRemainingArguments=$true)]$rest) & $cmd @rest }`
allows unchained `ALLOW_UNREVIEWED_PUSH=1 git push ...` commands to execute directly in Windows PowerShell while satisfying the hook's prefix parser.

## Antigravity native task and subagent management APIs

Expand Down
25 changes: 25 additions & 0 deletions memories/r-quarto.md
Original file line number Diff line number Diff line change
Expand Up @@ -1095,3 +1095,28 @@ Hit on [wai#128](https://github.com/Morrison-Lab/wai/issues/128) (byok ITPM/budg
upstream or suggested R package, unit tests must verify full `formals()`
equality (both argument names and default values) and output equivalence
across every supported target format, rather than testing only `names(formals())`.
- **`QUARTO_R` on Windows**:
When Quarto fails to discover an installed R binary on Windows for knitr execution,
set `$env:QUARTO_R = "C:\Program Files\R\R-4.5.1\bin\x64\R.exe"` (or the appropriate R executable path)
in the execution session.
- **Reticulate `py` binding in Quarto documents**:
In Quarto documents mixing R and Python via `reticulate`,
do not assign `py <- reticulate::py` in an early knitr setup chunk before Python runs.
Early binding caches an uninitialized environment that shadows subsequent Python evaluations.
Assign `py <- reticulate::py` inside or immediately following the chunk where Python code runs
so inline expressions (`` `r py$var` ``) access live variables.
- **Observable JS (OJS) table header background in dark-themed Quarto documents (unverified)**:
In `Morrison-Lab/mds` PR #52, a `.widget-panel` OJS panel with hardcoded dark text (`color: #222`)
showed a suspected dark-theme contrast issue on table headers,
attributed to an assumed Quarto dark-theme rule
(`div.observablehq table thead tr th { background-color: var(--bs-body-bg); }`)
resolving `--bs-body-bg` to `#222` and producing black-on-black headers.
That CSS-variable-resolution claim was never confirmed against Quarto's own source,
and no `.widget-panel` in `mds` actually renders a table yet, so the fix is unexercised.
The `custom.scss` change merged in mds#52 is broader than a single selector:
it sets `.widget-panel table`, `.widget-panel table thead tr th`,
and `.widget-panel table th, .widget-panel table td` together,
overriding `color`/`background-color` alongside the Bootstrap table custom properties
`--bs-table-color`, `--bs-table-bg`, `--bs-table-border-color`,
`--bs-table-striped-color`, and `--bs-table-striped-bg`.
Treat this as unverified until a real rendered table in a `.widget-panel` confirms it.
Loading