Repository navigation
ums: document QUARTO_R and reticulate py binding timing in quarto - #4138
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
- Fix inline-code-span escaping for `` `r py$var` `` (single-backtick form rendered as two empty code spans flanking plain text; needs outer delimiters with more backticks than the inner run). - Rewrite the OJS dark-theme table-header entry to accurately describe mds#52: the CSS-variable-resolution claim was never confirmed against Quarto's own source and no `.widget-panel` in mds renders a table yet, so the fix is unexercised. Also documents the actual (broader) set of selectors/properties mds#52 touched. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BvPx94rPKXAKktp5sgykUh
Contributor
|
Claude finished review — View run Good — the trailing blank-line minor nit from round 1 is also gone; both files end with a single Both previously-flagged issues have been addressed by commit
No new content was added since that fix commit beyond what's already reviewed (the VerdictReady for merge Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "c3c082c592b0f047f9866a6e590d2b7ff94ee40f",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "memories/r-quarto.md now uses correctly doubled backticks for the r py$var inline code span, verified by rendering with a CommonMark parser, and the OJS dark-theme entry is now explicitly hedged as unverified and accurately describes the broader merged CSS selectors from mds#52.",
"holistic_assessment": "Scope remains a small memory-documentation addition with no regression risk; both blocking findings from prior rounds are confirmed fixed against live verification tools, leaving no outstanding requirement, integration, or validation concern."
}Reviewed commit: b153f7e |
Contributor
Collaborator
Author
|
Review findings for whoever owns this branch. Another session (mine) started fixing this PR without claiming it; it is standing down and will not push here.
Posted by Claude Code (AI agent) --- not written by a human. |
This was referenced Oct 1, 2026
d-morrison
added a commit
that referenced
this pull request
Oct 1, 2026
Resolves the append collision at the same insertion point between this branch's RevealJS title-slide-overflow entry and #4138's QUARTO_R/reticulate/OJS entries -- not a semantic duplicate, kept both. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This was referenced Oct 1, 2026
This was referenced Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents: