docs: clarify goSPL coupling limitations - #92
Merged
Merged
Conversation
…d domain padding Documents three behaviors that came up while reviewing the coupling scheme for the manuscript: the coupling interval only gates *when* coupling fires (DES's dt is used as-is, not clamped to it); a remesh mid-interval doesn't disturb the coupling clock or reset GoSPL's elevation, but the time-averaged-velocity node-count guard can miss a remesh that preserves node count; and the goSPL mesh domain is fixed at init, so its padding fraction effectively bounds how much lateral extension the DES model can accumulate. Also fixes a stale comment on needs_elevation_reset that no longer matches the implementation. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Rqf5nW3ahreo3Skp1Lpss6
chaseshyu
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gospl_driver/README.mdcovering three behaviors clarified while reviewing the coupling scheme for the manuscript:gospl_coupling_interval_in_yr) only gates when coupling fires; DES's actualdtis passed to goSPL as-is, not clamped to the configured interval.GoSPLDriver::needs_elevation_resetingospl-driver.hppthat incorrectly claimed the flag is re-armed after remeshing (it is not, in the current implementation).Test plan
🤖 Generated with Claude Code
https://claude.ai/code/session_01Rqf5nW3ahreo3Skp1Lpss6