Skip to content

Review DynEarthSol #92 for doc updates: docs: clarify goSPL coupling limitations #24

Description

@github-actions

GeoFLAC/DynEarthSol#92 merged — docs: clarify goSPL coupling limitations

Summary

  • Adds a "Known Limitations" section to gospl_driver/README.md covering three behaviors clarified while reviewing the coupling scheme for the manuscript:
    • The coupling interval (gospl_coupling_interval_in_yr) only gates when coupling fires; DES's actual dt is passed to goSPL as-is, not clamped to the configured interval.
    • A remesh occurring mid-coupling-interval doesn't disturb the coupling clock or reset goSPL's elevation state, but the time-averaged-velocity calculation's node-count-only guard can miss a remesh that happens to preserve the top-boundary node count, silently differencing unrelated nodes.
    • The goSPL mesh domain (padding around the DES model's initial surface extent) is fixed at initialization and never regenerated, so the padding fraction effectively bounds how much lateral extension the DES model can accumulate before hitting boundary artifacts.
  • Fixes a stale comment on GoSPLDriver::needs_elevation_reset in gospl-driver.hpp that incorrectly claimed the flag is re-armed after remeshing (it is not, in the current implementation).

Test plan

Files changed

  • gospl_driver/README.md
  • gospl_driver/gospl-driver.hpp

Next step

Ask Claude Code to run the doc-sync procedure from CLAUDE.md against this PR.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions