Skip to content

fix: unload the previous player when Play is clicked again #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TzuHuanTai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: unload the previous player when Play is clicked again #128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions demo/demo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,11 @@ window.addEventListener('DOMContentLoaded', async () => {
: undefined;

if (video) {
if (player) {
await player.unload();
player.destroy();
}

// Pre-create srcObject and call play() NOW while we're inside the user gesture.
// The browser's autoplay policy ties play() permission to the gesture context;
// by the time tracks arrive asynchronously, the gesture is long gone.
Expand Down