feat(Quote Replies): Add action buttons to replies in post notes (visible) - #2112
Open
marcustyphoon wants to merge 46 commits into
Open
feat(Quote Replies): Add action buttons to replies in post notes (visible)#2112marcustyphoon wants to merge 46 commits into
marcustyphoon wants to merge 46 commits into
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Collaborator
Author
|
Thoughts for @AprilSylph consideration:
|
marcustyphoon
marked this pull request as ready for review
March 2, 2026 02:25
marcustyphoon
commented
Mar 2, 2026
| }; | ||
|
|
||
| const determineNoteReplyType = ({ noteProps, parentNoteProps }) => { | ||
| if (userBlogNames.includes(noteProps.note.blogName)) return false; |
Collaborator
Author
There was a problem hiding this comment.
Interesting note from testing: this line excludes quote replying yourself, which probably makes sense in general... but a) maybe it doesn't (something something group blogs), and b) that's inconsistent with the behavior on activity items, which totally does let you quote reply yourself!
(comment copied from previous PR)
Collaborator
Author
|
edit: Well, they were removed, so there would currently be no way to test code that handled them correctly (for if they ever return). |
marcustyphoon
marked this pull request as draft
March 17, 2026 18:44
marcustyphoon
marked this pull request as ready for review
March 19, 2026 11:12
Collaborator
Author
|
Hmmm... should these buttons be blue only when hovered... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adapted from #1662.
This implements a button at the bottom of certain replies in the post footer, allowing the user to activate Quote Replies directly from that location if they would have been able to from the relevant item in the activity notifications menu/page.
Note that the situations referenced by the three types of verbiage ("replied to your post", "replied to you in a post" and "mentioned you on a post") used in Quote Replies have overlap. It's common for a threaded reply to one of your comments on one of your posts to be all three of these! When using Quote Replies from the activity notifications page/popup, the verbiage used is of course the one from the notification tab you're on (the same notification will appear in multiple tabs). In the notes in a post footer, any of them could accurately be said to apply.
This PR (see
determineNoteReplyType) prioritizes them in the order"replied to you in a post" > "replied to your post" > "mentioned you on a post", which... I think makes sense? Most specific to most general.Hm—I guess we could add a "replied to you on your post" verbiage if we wanted to.
(aside: my understanding is that at some point, some of what we're talking about here may become officially referred to as "comments," not "replies." I have no idea what the story is on that so for now I'll keep saying "replies" I guess)
Testing steps
Confirm that "quote this reply" buttons are added to replies in the post notes, and function when clicked, in these cases:
Check that the correct mentioned/replied-to blog is where the post draft is created.
also:
edit: