Fix slow XLSX import path and theme-color conditional formatting crash#31
Open
mustafamansoor-applead wants to merge 8 commits into
Open
Fix slow XLSX import path and theme-color conditional formatting crash#31mustafamansoor-applead wants to merge 8 commits into
mustafamansoor-applead wants to merge 8 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first fix addresses the slow import path seen on larger or more complex
XLSX files. The importer now avoids unnecessary repeated XML work in the hot
path, which reduces import latency and makes workbook loading more stable in
the app.
The second fix addresses a workbook parsing crash caused by theme-based colors
in conditional formatting and DXF styles. Theme colors are now normalized once
at workbook load, and conditional-format font parsing uses the full workbook
style context. This prevents import failures on files like appointment-
schedule.xlsx that previously crashed during theme color resolution.