Skip to content

Unix file copy - #376

Open
adrazilo wants to merge 11 commits into
zowe:v1.x/stagingfrom
adrazilo:unixFileCopy
Open

Unix file copy#376
adrazilo wants to merge 11 commits into
zowe:v1.x/stagingfrom
adrazilo:unixFileCopy

Conversation

@adrazilo

@adrazilo adrazilo commented Nov 30, 2021

Copy link
Copy Markdown

Proposed changes

This PR fixes the unixFileCopy command on the mock server so that it properly updates the global directory and returns a message response.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

PR Checklist

  • If the changes in this PR are meant for the next release / mainline, this PR targets the "staging" branch.
  • My code follows the style guidelines of this project (see: Contributing guideline)
  • New and existing unit tests pass locally with my changes
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works, or describe a test method below

Testing

To test this feature, please consider the following test conditions:

  1. A folder/file can be copied to an from any path.
  2. A folder/file does not override an existing folder/file
  3. A folder/file that does not exist is not copied

Further comments

This is my first PR! It is also a great introductory task to working with the mock server.

adrazilo and others added 3 commits November 30, 2021 13:24
Signed-off-by: Alexandra Drazilov <adrazilo@uwo.ca>
Signed-off-by: Alexandra Drazilov <adrazilo@uwo.ca>

@DivergentEuropeans DivergentEuropeans left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, /copy endpoint looks good to me! 🍨 Tested forceOverwrite, newName attribs too, yield proper responses

TODOs make sense

Comment thread mock/server.py Outdated
Signed-off-by: Alexandra Drazilov <adrazilo@uwo.ca>
Signed-off-by: Alexandra Drazilov <adrazilo@uwo.ca>
Signed-off-by: Alexandra Drazilov <adrazilo@uwo.ca>
Signed-off-by: Alexandra Drazilov <adrazilo@uwo.ca>
Signed-off-by: Alexandra Drazilov <adrazilo@uwo.ca>
Signed-off-by: Alexandra Drazilov <adrazilo@uwo.ca>
Signed-off-by: Alexandra Drazilov <adrazilo@uwo.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: New

Development

Successfully merging this pull request may close these issues.

2 participants