Skip to content

Add regression tests for is-valid/is-invalid on range inputs#834

Merged
dyve merged 2 commits into
mainfrom
fix/range-validation-test
Jun 22, 2026
Merged

Add regression tests for is-valid/is-invalid on range inputs#834
dyve merged 2 commits into
mainfrom
fix/range-validation-test

Conversation

@dyve

@dyve dyve commented Jun 22, 2026

Copy link
Copy Markdown
Member

Summary

  • Range inputs correctly receive is-valid/is-invalid validation classes (Bootstrap 5 supports this)
  • No test existed to guard against regressions — add two focused tests using assertIn to verify the classes are present/absent on bound valid and invalid forms

Test plan

  • test_input_type_range_invalid — bound form with empty data → is-invalid present, is-valid absent
  • test_input_type_range_valid — bound form with valid data → is-valid present, is-invalid absent
  • Full test suite passes (137 tests)

🤖 Generated with Claude Code

Guards against future regressions where validation classes could
accidentally be removed from range inputs, which Bootstrap 5 supports.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coveralls

coveralls commented Jun 22, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 27935753341

Coverage remained the same at 96.014%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 676
Covered Lines: 654
Line Coverage: 96.75%
Relevant Branches: 202
Covered Branches: 189
Branch Coverage: 93.56%
Branches in Coverage %: Yes
Coverage Strength: 14.51 hits per line

💛 - Coveralls

@dyve dyve merged commit 1dfdafe into main Jun 22, 2026
21 checks passed
@dyve dyve deleted the fix/range-validation-test branch June 22, 2026 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants