Repository navigation
chore: update ssl submodule for OpenSSL 4.0 support - #36
Merged
Merged
Conversation
Bump src/ssl to 65edff2 (zhaojh329/ssl#9): - Use SSL_set1_dnsname()/SSL_set1_ipaddr() with OpenSSL 4.0, where SSL_set1_host() is deprecated. Before, the build failed with OpenSSL 4.0 because of -Werror. - Use the include and library directories pkg-config reports for OpenSSL. Before, an OpenSSL outside the default paths was found, but the build used the system OpenSSL. Tested the HTTPS example server with OpenSSL 4.0.3 and 3.0.2, using EC and RSA certificates with TLS 1.2 and 1.3. Also built with wolfSSL and Mbed TLS 2.28.0, 3.6.7 and 4.1.1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the
src/sslsubmodule from b385396 to 65edff2, the merge of zhaojh329/ssl#9:SSL_set1_dnsname()/SSL_set1_ipaddr()replace the deprecatedSSL_set1_host().Before, libuhttpd failed to build against OpenSSL 4.0, because it builds with
-Werrorby default:Before, an OpenSSL outside the default paths was found (
Found openssl, version 4.0.3), butlibuhttpd.sowas built against the system OpenSSL and linkedlibssl.so.3.The
SSL_set1_host()call is only used on the client side, butopenssl.cis always compiled, so thebuild failure affects libuhttpd too. The server code is unchanged.
Testing
Built on Ubuntu 22.04 (gcc 11) on top of current master (42a7a75), without warnings, against:
PKG_CONFIG_PATH;libuhttpd.solinkslibssl.so.4);-DSSL_SUPPORT=OFF.With OpenSSL 4.0.3 and 3.0.2, I ran
example/simple_server -swith EC and RSA certificates, using TLS1.2 and 1.3. In all 8 combinations, these work:
/echo;Connection: closerequest.A quick run with wolfSSL and Mbed TLS 4.1.1 (GET, download, and closing after an HTTP/1.0 request, with
TLS 1.2 and 1.3) also passes.
rtty gets the same submodule update in zhaojh329/rtty#167.