Add fiat-denominated send amounts to the iMessage app#74
Open
edwardbickerton wants to merge 2 commits into
Open
Add fiat-denominated send amounts to the iMessage app#74edwardbickerton wants to merge 2 commits into
edwardbickerton wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #67
The iMessage send flow was sat-only. This brings it in line with the main
app so users can enter an amount in their preferred fiat currency and have
it converted to sats.
Changes
TextFieldwithNumericalInputView, the sameamount-entry component the main app uses (fiat entry + live sat conversion).
the existing
group.com.cypherbase.macadamiaapp group (both targets alreadydeclare the entitlement), so the setting stays in sync.
AppStateintoCurrency.fetchBitcoinExchangeRates()and reuse it from both targets(no duplicated logic).
PreferredCurrencyConversionUnitvalue from standarddefaults into the shared store on launch, so current users keep their setting.
Testing
Happy to adjust based on review. Worth a build of both the app and the
macadamiaMessages extension and a quick run through the iMessage send flow
with a fiat preference set to confirm conversion and token creation.